This patch creates a helper function vote_up_down_hasvoted() to check if the user has already voted on a node/comment. If not, it hides the 'Reset vote' link.

CommentFileSizeAuthor
#10 only-show-reset-if-voted-1.x.patch3.78 KBmarvil07
#10 only-show-reset-if-voted-2.x-3.x.patch3.11 KBmarvil07
#9 vote_up_down.module.patch3.23 KBquotesbro
#7 vote_up_down.module.patch2.43 KBquotesbro
#1 vote_up_down_reset_link.patch1.78 KBmatt@antinomia
vote_up_down_reset_link.patch8.47 KBmatt@antinomia

Comments

matt@antinomia’s picture

matt@antinomia commented
StatusFileSize
new vote_up_down_reset_link.patch1.78 KB

Rerolled against -dev. Also cleaned up patch, removing vote_up_down_hasvoted() in favor of VotingAPI's votingapi_get_user_votes() which does the same.

kirie’s picture

kirie commented

Instead of having the 'Reset vote' link, would it be better to allow resetting a vote (if present) through the voting vidget?

quotesbro’s picture

quotesbro commented
Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community
quotesbro’s picture

quotesbro commented

This patch work for 5.x.

It is necessary for version 6.x too but in 6.x other functions

lut4rp’s picture

lut4rp commented
Status: Reviewed & tested by the community » Fixed

Fixed!

lut4rp’s picture

lut4rp commented
Status: Fixed » Needs work

err, wrong fix. Sorry :-/

quotesbro’s picture

quotesbro commented
Version: 5.x-1.x-dev » 6.x-1.0-beta6
Status: Needs work » Needs review
StatusFileSize
new vote_up_down.module.patch2.43 KB

patch for 6.x-1.0

ingo86’s picture

ingo86 commented
Assigned: Unassigned » ingo86

Will look to add this patch asap. Stay tuned for beta7.

quotesbro’s picture

quotesbro commented
StatusFileSize
new vote_up_down.module.patch3.23 KB

Please don't use patch #7
here is a better variant

marvil07’s picture

marvil07 commented
Status: Needs review » Fixed
StatusFileSize
new only-show-reset-if-voted-2.x-3.x.patch3.11 KB
new only-show-reset-if-voted-1.x.patch3.78 KB

I made three changes:

- Since #544962: use votingapi for uid criteria, there is no more _vote_up_down_get_uid(), in favour of votingapi_current_user_identifier()
- Fix data member for comment, cid instead of nid.
- Use explicitly is_null() at the conditional

Then, I commited this to 1.x, port this to 2.x/3.x and commit it also to 2.x/3.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.