Only show 'Reset vote' link if user has voted on node/comment [#210905]

This patch creates a helper function vote_up_down_hasvoted() to check if the user has already voted on a node/comment. If not, it hides the 'Reset vote' link.

Comment	File	Size	Author
#10	only-show-reset-if-voted-1.x.patch	3.78 KB	marvil07
#10
#10	only-show-reset-if-voted-2.x-3.x.patch	3.11 KB	marvil07
#10
#9	vote_up_down.module.patch	3.23 KB	quotesBro
#9
#7	vote_up_down.module.patch	2.43 KB	quotesBro
#7
#1	vote_up_down_reset_link.patch	1.78 KB	matt@antinomia
#1
	vote_up_down_reset_link.patch	8.47 KB	matt@antinomia

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

matt@antinomia CreditAttribution: matt@antinomia commented 18 January 2008 at 21:22

File	Size
vote_up_down_reset_link.patch	1.78 KB

Rerolled against -dev. Also cleaned up patch, removing vote_up_down_hasvoted() in favor of VotingAPI's votingapi_get_user_votes() which does the same.

Comment #2

kirie CreditAttribution: kirie commented 30 January 2008 at 06:11

Instead of having the 'Reset vote' link, would it be better to allow resetting a vote (if present) through the voting vidget?

Comment #3

quotesBro CreditAttribution: quotesBro commented 28 February 2009 at 18:19

Priority:	Minor	» Normal
Status:	Needs review	» Reviewed & tested by the community

Comment #4

quotesBro CreditAttribution: quotesBro commented 28 February 2009 at 18:33

This patch work for 5.x.

It is necessary for version 6.x too but in 6.x other functions

Comment #5

lut4rp CreditAttribution: lut4rp commented 5 April 2009 at 12:12

Status:

Reviewed & tested by the community

» Fixed

Fixed!

Comment #6

lut4rp CreditAttribution: lut4rp commented 5 April 2009 at 12:13

Status:

Fixed

» Needs work

err, wrong fix. Sorry :-/

File	Size
vote_up_down.module.patch	2.43 KB

Comment #8

ingo86 CreditAttribution: ingo86 commented 6 September 2009 at 13:57

Assigned:

Unassigned

» ingo86

Will look to add this patch asap. Stay tuned for beta7.

Comment #9

quotesBro CreditAttribution: quotesBro commented 7 March 2010 at 10:23

File	Size
vote_up_down.module.patch	3.23 KB

Please don't use patch #7
here is a better variant

File	Size
only-show-reset-if-voted-2.x-3.x.patch	3.11 KB

only-show-reset-if-voted-1.x.patch	3.78 KB

- Since #544962: use votingapi for uid criteria, there is no more _vote_up_down_get_uid(), in favour of votingapi_current_user_identifier()
- Fix data member for comment, cid instead of nid.
- Use explicitly is_null() at the conditional

Then, I commited this to 1.x, port this to 2.x/3.x and commit it also to 2.x/3.x.