Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Updated: Comment #0
Problem/Motivation
Vertical Tabs are intentionally disabled when viewed in a narrow viewport. Which means that any code that assumes it can call tabHide() or tabShow() will break.
This is the case for filter.admin.js. It doesn't break, but it also stops showing/hiding the <details> (which are converted into Vertical Tabs when the screen is sufficiently wide) that contains a filter's settings when the corresponding filter is enabled/disabled.
Proposed resolution
Just show/hide the <details> element containing filter settings instead when Vertical Tabs aren't enabled.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Related Issues
Discovered thanks to #2102019-4: Vertical tabs looks broken on small screens.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | filter_settings_narrow-2108955-1.patch | 2.29 KB | wim leers |
Comments
Comment #1
wim leersComment #2
wim leers.
Comment #3
nod_This should mess with the open attribute instead of show/hide from jQuery
Comment #4
wim leersHuh? It already was using
.tabShow()before. I'm merely fixing it. If using theopenattribute is the better solution, that's fine, but that's an improvement task, this is a bug fix!Comment #5
nod_That works, it's not a matter of collapsing/expanding details element, it's a matter of showing them or not to begin with. That works.
Comment #6
webchickCommitted and pushed to 8.x. Thanks!
Comment #7
wim leersHurray! :)