We've just updated to media 2.0 alpha2 and note that there is a javascript error in IE that causes the wysiwyg editor to not launch....

This was introduced in #1970370: Split media token handling from WYSIWYG integration javascript, specifically the patch from #5 changed the replaceTokenWithPlaceholder function to use Array.indexOf

I'm not sure whether it would be best to revert to not use indexOf or whether Array.prototype.indexOf should be added to this file to ensure backwards compatiblity for user agents that don't support it.

see : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global...

CommentFileSizeAuthor
#4 media-indexOf-IE-2108647-4.patch433 bytesParisLiakos
#2 media-indexOf-IE-2108647.patch464 bytesParisLiakos

Comments

ParisLiakos’s picture

ParisLiakos commented
Version: 7.x-2.0-alpha2 » 7.x-2.x-dev

we should use $.inArray instead

ParisLiakos’s picture

ParisLiakos commented
Status: Active » Needs review
StatusFileSize
new media-indexOf-IE-2108647.patch464 bytes

Status: Needs review » Needs work

The last submitted patch, media-indexOf-IE-2108647.patch, failed testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs work » Needs review
StatusFileSize
new media-indexOf-IE-2108647-4.patch433 bytes
sheise’s picture

sheise commented

Having the same issue. Patch from #4 seems to do the trick.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: javascript error in IE, js/media.filter.js -- Array.indexOf doesn't exist! » javascript error in IE, js/media.filter.git commit -m "Issue #2108647 by ParisLiakos | tswaterjs -- Array.indexOf doesn't exist!
Status: Needs review » Fixed

Committed #4 to 7.x-2.x. http://drupalcode.org/project/media.git/commit/c611130

ParisLiakos’s picture

ParisLiakos commented
Title: javascript error in IE, js/media.filter.git commit -m "Issue #2108647 by ParisLiakos | tswaterjs -- Array.indexOf doesn't exist! » Array.indexOf doesn't exist!

thanks:)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.