I've added a configuration form to allow sitebuilders to select which taxonomy vocabulary will be used to store issue tags scraped from d.o, as well as setting the master tag to be scraped.

Comments

dsayswhat’s picture

Status: Active » Needs review
StatusFileSize
new1.93 KB

See if you think this is worthwhile...

gábor hojtsy’s picture

Status: Needs review » Needs work

Thanks for this patch. It is great to have incremental updates to this module, which are easier to review and incorporate.

  1. +++ b/rocketship.module
    @@ -27,6 +28,14 @@ function rocketship_menu() {
    +    'title' => 'Rocketship Configuration',
    

    IMHO "Rocketship settings" is the admin page naming standard? (Lowercase, and wording)

  2. +++ b/rocketship.module
    @@ -60,6 +69,37 @@ function rocketship_launch_form_submit() {
    +  $form['rocketship_master_tag'] = array(
    +    '#type' => 'textfield',
    +    '#default_value' => variable_get('rocketship_master_tag', 'D8MI'),
    +    '#description' => t('Issue tag from drupal.org for the initiative this site is serving.'),
    +  );
    

    Its strange how you don't provide a title but provide a description instead. I'd title this "Drupal.org master tag".

  3. +++ b/rocketship.module
    @@ -60,6 +69,37 @@ function rocketship_launch_form_submit() {
    +  $form['rocketship_tags_vid'] = array(
    +    '#type'             => 'select',
    +    '#title'            => t('List of current Vocabularies.'),
    +    '#position'         => 'left' ,
    +    '#options'          => $vocabs,
    +    '#default_value'    => variable_get('rocketship_tags_vid', '2'),
    +    '#description'      => t('Taxonomy vocabulary containing tags for your issues')
    

    The title of this field is pretty misleading. The goal of the field is to pick a "Local vocabulary for saving tags" right? :)

    Also what is #position and why?

lewisnyman’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new1.84 KB

Here's an update based on the feedback, I also struggled with the wording for the vocab item.

gábor hojtsy’s picture

Status: Needs review » Fixed
StatusFileSize
new1.88 KB
new2.02 KB

Fixed some UI stuff, eg. no dots at end of titles, and made the descriptions true to the behaviour. Committing this one.

  • Commit 91c9a0b on 7.x-1.x by Gábor Hojtsy:
    Issue #2106083 by Gábor Hojtsy, LewisNyman, dsayswhat: Added Make...
gábor hojtsy’s picture

Posted a followup at #1952494: Make the leader exclusion optional making the lead user configurable on this UI and making the two fields added here required.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.