Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

statistics.settings.yml
views.view.test_statistics_integration.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

CommentFileSizeAuthor
#4 2105991-4-statistics-yaml-variable-type.patch8.17 KBnonsie
#1 2105991-1-statistics-yaml-variable-type.patch7.82 KBalexander_danilenko

Comments

alexander_danilenko’s picture

alexander_danilenko commented
Assigned: Unassigned » alexander_danilenko
Status: Active » Needs review
StatusFileSize
new 2105991-1-statistics-yaml-variable-type.patch7.82 KB

Status: Needs review » Needs work

The last submitted patch, 2105991-1-statistics-yaml-variable-type.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented 
+++ b/core/modules/statistics/tests/modules/statistics_test_views/test_views/views.view.test_statistics_integration.yml
@@ -3,7 +3,7 @@ base_field: nid
-status: '1'
+status: 1

@@ -34,17 +34,17 @@ display:
-            alter_text: '0'
-            make_link: '0'
-            absolute: '0'
-            trim: '0'
-            word_boundary: '0'
-            ellipsis: '0'
-            strip_tags: '0'
-            html: '0'
-          hide_empty: '0'
-          empty_zero: '0'
-          link_to_node: '1'
+            alter_text: 0
+            make_link: 0
+            absolute: 0
+            trim: 0
+            word_boundary: 0
+            ellipsis: 0
+            strip_tags: 0
+            html: 0
+          hide_empty: 0
+          empty_zero: 0
+          link_to_node: 1

@@ -54,46 +54,46 @@ display:
-          exclude: '0'
+          exclude: 0
...
-            alter_text: '0'
+            alter_text: 0
...
-            make_link: '0'
+            make_link: 0
...
-            absolute: '0'
-            external: '0'
-            replace_spaces: '0'
+            absolute: 0
+            external: 0
+            replace_spaces: 0
             path_case: none
-            trim_whitespace: '0'
+            trim_whitespace: 0

bool should be true (for 1) and false (for 0)

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
Assigned: alexander_danilenko » nonsie
Status: Needs work » Needs review
StatusFileSize
new 2105991-4-statistics-yaml-variable-type.patch8.17 KB

Here's an updated patch with true and false

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Patch still applies and good to go.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.