Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

Fix and issue patch for below config files:
custom_block.type.basic.yml
entity.view_mode.custom_block.full.yml
block.block.stark.test_block.yml
views.view.test_view_block.yml
views.view.test_view_block2.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

CommentFileSizeAuthor
#14 interdiff.txt441 bytesfoxtrotcharlie
#14 2105915-block-test-config-14.patch3.1 KBfoxtrotcharlie
#12 2105915-block-test-config-12.patch3.53 KBvijaycs85
#5 2105915-diff-3-5.txt2.47 KBvijaycs85
#5 2105915-block-test-config-5.patch3.28 KBvijaycs85
#3 2105915-block-yml-type-casting-3.patch3.24 KBfoxtrotcharlie
#1 2105915-block-yml-type-casting-1.patch4.2 KBvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new 2105915-block-yml-type-casting-1.patch4.2 KB

Initial patch...

benjy’s picture

benjy commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

Needs a reroll.

foxtrotcharlie’s picture

foxtrotcharlie commented
Assigned: Unassigned » foxtrotcharlie
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2105915-block-yml-type-casting-3.patch3.24 KB

My first reroll - hope it's right...

foxtrotcharlie’s picture

foxtrotcharlie commented

I just noticed that in block_test_theme.info.yml and entity.view_mode.custom_block.full.yml the booleans true and false are lowercase and not uppercase. Should they be changed to uppercase? There is also a value of '-1' (in the single quotes) in block.block.test_block.yml and I wonder if it the quotes should be removed?

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 2105915-block-test-config-5.patch3.28 KB
new 2105915-diff-3-5.txt2.47 KB

Fixing the conversions missed in #3

benjy’s picture

benjy commented

Is there any reason why we're not fixing up "block.routing.yml" here as well? eg the _access_theme properties.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

@benjy the meta is more about the config, routing or info aren't config.

benjy’s picture

benjy commented
Status: Needs review » Reviewed & tested by the community

OK sounds good.

xjm’s picture

xjm
she/her
Primary language English
commented

5: 2105915-block-test-config-5.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
commented

5: 2105915-block-test-config-5.patch queued for re-testing.

The last submitted patch, 5: 2105915-block-test-config-5.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2105915-block-test-config-12.patch3.53 KB

Re-rolling...

benjy’s picture

benjy commented 
+++ b/core/modules/block/tests/modules/block_test/block_test.info.yml
@@ -4,4 +4,4 @@ description: 'Provides test blocks.'
+hidden: TRUE

Why is this uppercase now?

foxtrotcharlie’s picture

foxtrotcharlie commented
StatusFileSize
new 2105915-block-test-config-14.patch3.1 KB
new interdiff.txt441 bytes

I've changed the uppercase TRUE back to lowercase true. According to this comment by chx and this info in the Symfony documentation, Symfony uses lowercase for booleans.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

Sorry for my mistake... +1 to RTBC.

benjy’s picture

benjy commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.