API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Dependenc...

Enter a descriptive title (above) relating to interface ContainerInjectionInterface, then describe the problem you have found:

The docs for this interface ContainerInjectionInterface look like they were just left over from when it maybe was named ControllerInterface or copy/pasted from there. They need to be updated to reflect what the interface actually does/is/should be used for.

As this documentation is pretty much unrelated to the class (assuming that the name is a sensible choice), it's a major bug, especially since every route controller class is supposed to extend this interface so it's fairly prominent.

CommentFileSizeAuthor
#3 2105693-3.patch2.17 KBcilefen

Comments

tim.plunkett’s picture

#2165475: Provide a generic class resolver better codifies where this is used, and writing these docs might be easier once that's in. Not blocked by any means though.

dawehner’s picture

Issue tags: -MenuSystemRevamp

Remove pointless tag.

cilefen’s picture

Status: Active » Needs review
StatusFileSize
new2.17 KB
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks reasonable to me, thanks!

cilefen’s picture

I am glad I have hacked away at core enough now to have seen this pattern a lot.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 957078e and pushed to 8.0.x. Thanks!

  • alexpott committed 957078e on 8.0.x
    Issue #2105693 by cilefen | jhodgdon: Fixed ContainerInjectionInterface...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.