CommentFileSizeAuthor
#6 move_controller_to_controller_folder_toolbar_module-2104727-6.patch3.44 KBSam152
#2 move_controller_to_controller_folder_toolbar_module-2104727-2.patch1.3 KBwesleydv
#1 move_controller_to_controller_folder_toolbar_module-2104727-1.patch2.46 KBwesleydv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wesleydv’s picture

wesleydv CreditAttribution: wesleydv commented
Status: Active » Needs review
FileSize
move_controller_to_controller_folder_toolbar_module-2104727-1.patch2.46 KB

Patch!

wesleydv’s picture

wesleydv CreditAttribution: wesleydv commented
FileSize
move_controller_to_controller_folder_toolbar_module-2104727-2.patch1.3 KB

Better patch now includes a rename

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Reviewed & tested by the community

Nice one @wesleydv. RTBC. Consistency++

The last submitted patch, move_controller_to_controller_folder_toolbar_module-2104727-2.patch, failed testing.

wesleydv’s picture

wesleydv CreditAttribution: wesleydv commented
Status: Needs work » Needs review

#2: move_controller_to_controller_folder_toolbar_module-2104727-2.patch queued for re-testing.

Sam152’s picture

Sam152 CreditAttribution: Sam152 commented
Issue summary: View changes
FileSize
move_controller_to_controller_folder_toolbar_module-2104727-6.patch3.44 KB

#2 no longer applies. Attached a rerolled patch.

abelass’s picture

abelass CreditAttribution: abelass commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Tested the toolbar ans checked the code.

Everything is fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 6c3fbad and pushed to 8.x. Thanks!

@Sam152 you need to add the following to your git config

[diff]
        renames = copies

See https://drupal.org/documentation/git/configure

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Mh, this broke toolbar, see #2187991: toolbar access checking points to wrong namespace

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.