I'm pretty sure this isn't a dupe, but please correct me if I'm wrong (new bootstrap user). When creating a subtheme with the starter subtheme, I received several missing variable errors when compiling style.less with lessc. I copied the missing variables from the Bootstrap source variables.less file to update the subtheme's copy.

The attached patch restores headings, nav-pills-border-radius, breadcrumb-seperator, and responsive layout/grid variables. I see the deprecation notices for the device name variables slated for Bootstrap 3.0.1. I've put 'em back in, but sounds like they're about to come out?

CommentFileSizeAuthor
#3 less-vars-2104549-3.patch562 bytesherom
bootstrap_subtheme_less_variables.patch3.82 KBthumb

Comments

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Active » Fixed

Thanks @thumb!

Committed d18b235 to 7.x-3.x:

Issue #2104549 by thumb: Missing Less variables in subtheme when compiling style.less with lessc (using Bootstrap source files)

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
commented

Well, i can't say.

This patch only work for master branch. If someone using bower, or download the release package for v.3.0.0, its gonna be another error when compiling less.

herom’s picture

herom commented
Status: Fixed » Needs review
StatusFileSize
new less-vars-2104549-3.patch562 bytes

@container-lg-desktop shouldn't have been removed in the patch.
let's bring it back.

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
commented

Maybe all deprecated variables shouldn't be removed until v.3.0.1 released

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed

Thanks @herom!

Committed ff68577 to 7.x-3.x:

Issue #2104549 by herom, thumb: Missing Less variables in subtheme when compiling style.less with lessc (using Bootstrap source files)

valkum’s picture

valkum commented
Version: 7.x-3.x-dev » 7.x-3.0-rc2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.