Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Currently, MailManager is being used directly to send digest messages. Users may want to use some notifier besides email such as SMS to send the digests, so we should be using the message notify instead to add the flexibility.
Comment | File | Size | Author |
---|---|---|---|
#12 | message_digest-send_using_message_notify-2103013-12.patch | 8.13 KB | joel_osc |
#9 | message_digest_notify.png | 145.87 KB | joel_osc |
#9 | message_digest-send_using_message_notify-2103013-9.patch | 8.12 KB | joel_osc |
Comments
Comment #1
mcrittenden CreditAttribution: mcrittenden commentedComment #2
benstjohn CreditAttribution: benstjohn commentedI'm fairly new to drupal but if this issue was fixed would it enable say modules like message_subscribe to utilize the message_digest module?
Comment #3
mcrittenden CreditAttribution: mcrittenden commentedmessage_subscribe should be able to use message_digest already as far as I know, without this issue being fixed. Are you seeing a specific issue?
Comment #4
benstjohn CreditAttribution: benstjohn commentedNo your right :)
Comment #5
Renee S CreditAttribution: Renee S commentedComment #6
mcrittenden CreditAttribution: mcrittenden commentedFor the record, I'm most likely not going to implement this specific feature myself, so keeping open in hopes that someone comes along with a patch.
Comment #7
gandhiano CreditAttribution: gandhiano as a volunteer and commentedI am trying to add this to a Drupal Commons site (still running 3.12) and it does work only partially, because while the digest is sent, default direct e-mail notifications are also still sent.
I am not sure if the problem relates to this issue, but would like to hear your impressions. If yes, I may come to contribute a patch.
Comment #8
gandhiano CreditAttribution: gandhiano as a volunteer and commentedRe-reading I notice that this is unrelated to my current issue. It would be nice, as would open possibility for abstracting and e.g. using SMS framework or others, but definitely not my priority atm.
Comment #9
joel_osc CreditAttribution: joel_osc at OpenPlus commentedHere is a patch that adds this functionality by adding two new fields to the interval entity that allow the user to configure which notifiers are to be used and which template to use for the message. Note that the patch also includes this fix #3225949: Drupal 9 compability with changes to MessageNotifierBase. I am setting this to Needs review to hopefully get some maintainer attention to carry it the last mile.
There are a couple of remaining things that will need to be addressed:
Many thanks for the great work on this module!
Comment #10
joel_osc CreditAttribution: joel_osc at OpenPlus commentedComment #11
joel_osc CreditAttribution: joel_osc at OpenPlus commented@gandhiano I have the same issue... it seems that message_notify depends on message_subscribe_email that has an alter hook that adds the email notification. The only way I could find to stop it was to remove its alter hook:
Comment #12
joel_osc CreditAttribution: joel_osc at OpenPlus commentedRe-roll of patch in #9 to work with latest release.