Follow-up from #2097123-24: Deprecate comment_num_new() in favour of method on CommentManager

CommentFileSizeAuthor
#9 drupal8.simpletest-module.2102539-9-fail.patch1.91 KBandypost
#9 drupal8.simpletest-module.2102539-8.patch2.86 KBandypost
#8 drupal8.simpletest-module.2102539-8-fail.patch964 bytesandypost
#8 drupal8.simpletest-module.2102539-8.patch2.86 KBandypost
#6 interdiff.txt1.97 KBandypost
#6 drupal8.simpletest-module.2102539-6.patch2.86 KBandypost
#2 drupal8.simpletest-module.2102539-2.patch2.31 KBandypost
#1 drupal8.simpletest-module.2102539-1.patch2.31 KBandypost

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new drupal8.simpletest-module.2102539-1.patch2.31 KB

At least this

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new drupal8.simpletest-module.2102539-2.patch2.31 KB

The right test

andypost’s picture

andypost
he/him
Primary language Russian
commented
Priority: Normal » Major

Suppose this major because testing broken

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented 
+++ b/core/modules/simpletest/lib/Drupal/simpletest/Tests/SimpleTestTest.php
@@ -64,8 +64,11 @@ function testInternalBrowser() {
+      $this->assertNotEqual($current_user, $this->container->get('current_user')->id(), 'Current user service updated.');

$current_user->id() instead?

andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/core/modules/simpletest/lib/Drupal/simpletest/Tests/SimpleTestTest.php
@@ -64,8 +64,11 @@ function testInternalBrowser() {
+      $current_user = $this->container->get('current_user')->id();
...
+      $this->assertNotEqual($current_user, $this->container->get('current_user')->id(), 'Current user service updated.');

probably better name it $current_user_id

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new drupal8.simpletest-module.2102539-6.patch2.86 KB
new interdiff.txt1.97 KB

Tune this up

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Unless bot disagrees

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new drupal8.simpletest-module.2102539-8.patch2.86 KB
new drupal8.simpletest-module.2102539-8-fail.patch964 bytes

forget to add fail patch

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new drupal8.simpletest-module.2102539-8.patch2.86 KB
new drupal8.simpletest-module.2102539-9-fail.patch1.91 KB

messed patches, fail patch with test only

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Still RTBC but now demonstrates failing HEAD.
Great work.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 2d10571 and pushed to 8.x. Thanks!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Great to see this fixed, but it wasn't really a bug... This never worked with global $user either.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.