Remove drupal_set_title in custom block module controllers and entitylist controllers

A lot of that isn't needed.

+++ b/core/modules/block/custom_block/custom_block.routing.yml
@@ -16,6 +17,7 @@ custom_block.add_form:
+    _title_callback: 'Drupal\custom_block\Controller\CustomBlockController::geFormTitle'

ge FORM!

Ha

+++ b/core/modules/block/custom_block/custom_block.module
@@ -99,11 +99,9 @@ function custom_block_menu() {
-    'title' => 'Add custom block',
     'route_name' => 'custom_block.add_page',
   );
   $items['block/add/%custom_block_type'] = array(
-    'title' => 'Add custom block',

These need to be left in until #2047633: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit goes in

I re-roll the patch to remove the deletion of menu entries based in #8 by @tim.plunkett

This looks good to me.

#9: drupal8.block-module.2102369-9.patch queued for re-testing.

The patch works fine. Blocks titles are still displayed in the menu link or on the admin block pages.

As said in #1 there are 2 left drupal_set_title function.

1. CustomBlockTypeListController->render()
2. CustomBlockFormController->form().

Hi @vijaycs85,

I think there is too much things in your patch (39 files changed, 428 insertions, 360 deletions).

#18: 2102369-block-title-18.patch queued for re-testing.

1. --- a/core/lib/Drupal/Core/Entity/EntityListController.php
   +++ b/core/lib/Drupal/Core/Entity/EntityListController.php
   
   @@ -249,4 +250,15 @@ public function setTranslationManager(TranslationInterface $translation_manager)
   +   * Returns the title of the form.
   

   It seems odd to talk about forms even we are on a listing.

2. +++ b/core/modules/block/custom_block/lib/Drupal/custom_block/CustomBlockTypeListController.php
   @@ -51,9 +51,14 @@ public function buildRow(EntityInterface $entity) {
       * {@inheritdoc}
       */
      public function render() {
   -    // @todo Remove this once https://drupal.org/node/2032535 is in.
   -    drupal_set_title(t('Custom block types'));
        return parent::render();
      }
   

   If you remove the drupal_set_title() call all you have is return parent::render() so it can be dropped.

Re-rolled and applied @dawehner suggestions on #21.

This seems fine for me now.

+++ b/core/modules/block/custom_block/custom_block.routing.yml
@@ -16,6 +17,7 @@ custom_block.add_form:
+    _title_callback: 'Drupal\custom_block\Controller\CustomBlockController::getFormTitle'

+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Controller/CustomBlockController.php
@@ -98,10 +99,6 @@ public function add(Request $request) {
-    // @todo Remove this when https://drupal.org/node/1981644 is in.
-    drupal_set_title(t('Add %type custom block', array(
-      '%type' => $custom_block_type->label()
-    )), PASS_THROUGH);

@@ -114,4 +111,17 @@ public function addForm(CustomBlockTypeInterface $custom_block_type, Request $re
+  /**
+   * Provides the page title for this controller.
+   *
+   * @param \Drupal\custom_block\CustomBlockTypeInterface $custom_block_type
+   *   The custom block type being added.
+   *
+   * @return string
+   *   The page title.
+   */
+  public function getFormTitle(CustomBlockTypeInterface $custom_block_type) {

How about getAddFormTitle? The function doc block and name are not consistent. Also can't we just return the title on the form array?

+++ b/core/lib/Drupal/Core/Entity/EntityListController.php
@@ -202,6 +202,7 @@ public function render() {
+      '#title' => $this->getTitle(),

@@ -249,4 +250,15 @@ public function setTranslationManager(TranslationInterface $translation_manager)
+  /**
+   * Returns the title of the page.
+   *
+   * @return string
+   *   A string title of the page.
+   *
+   */
+  protected function getTitle() {
+    return;
+  }

Also, this is way bigger than block module. Can we either reduce the scope or retitle the issue?

Changed the title to getAddFormTitle. Can't add the page title directly to the form as the form is called both for /block/add and /block/add/{custom_block_type} but they have two different page titles and no way as far as I can see of distushing the two different times the form is called particularly if the custom_block_type is basic.

Needs reroll.

Rerolled patch #26.

Woops. Fixed the whitespace.

Patch attached.

Back to RTBC

30: 2102369-block-title-30.patch queued for re-testing.

+++ b/core/lib/Drupal/Core/Entity/EntityListController.php
@@ -249,4 +250,15 @@ public function setTranslationManager(TranslationInterface $translation_manager)
+  protected function getTitle() {

Why add this on the controller but not the interface? It's only used internal to the class so maybe that's OK and we say this an internal implementation detail of the base class, but I don't think this was discussed. It could also be protected if it's not in the interface.

this an internal implementation detail of the base class

I don't think it was explicitly discussed, but I agree with this statement. It's fine as is.

Works for me. Committed/pushed to 8.x, thanks!