Very similar to #1320036: No method getElementName for this instance of the class RulesOr - when on the admin/people/create page.

CommentFileSizeAuthor
#1 commerce-no-method-getelementname-2102235-1.patch1.17 KBheddn

Comments

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Needs review
StatusFileSize
new commerce-no-method-getelementname-2102235-1.patch1.17 KB

This is the fix that was in related #1320036: No method getElementName for this instance of the class RulesOr - when on the admin/people/create page

rszrama’s picture

rszrama commented
Category: bug » task
Status: Needs review » Postponed (maintainer needs more info)

In what scenario would a Rules action not have this method, though? It's pretty much a requirement for action objects given the RulesAbstractPlugin has this method.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Postponed (maintainer needs more info) » Needs review

RulesAnd, RulesLoop, RulesOr extend off RulesPlugin, not RulesAbstractPlugin. I know that #1698296: [Meta] Merge Conditional Rules isn't in rule core (yet), but we should still support rules_conditional.

rszrama’s picture

rszrama commented

Hmm, so I suppose someone has a payment method rule using a RulesLoop? If so, should we update this function to traverse the loop?

rszrama’s picture

rszrama commented
Issue summary: View changes
Status: Needs review » Fixed

I went ahead and committed the patch, but I changed method_exists() to is_callable().

Commit: http://drupalcode.org/project/commerce.git/commitdiff/b61ef0e

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.