I've updated the module to it's latest version and when I try to save the workflow settings, even if I don't change anything, I get the Enter the URI of your stopwords.txt file: At stopwords file or words are required. error message.

Seems like the SearchApiStopWords::configurationFormValidate() is always validating stopwords without even checking if they are enabled.

CommentFileSizeAuthor
#1 2100671-1--no_stopwords_specified.patch1.8 KBdrunken monkey

Comments

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes

added info

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Version: 7.x-1.8 » 7.x-1.x-dev
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2100671-1--no_stopwords_specified.patch1.8 KB

Thanks for reporting this issue. This is of course rather stupid behavior, you are right. It might even be a good idea to fix this by just never validating the configuration forms of disabled plugins.
However, in this case I think the simpler fix is to just not check for either of them being specified – if none is, the processor will do nothing, but what's the harm in that?
Patch attached.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: Framework » Plugins
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.