Change notice: Need support for adding metadata in hook_views_data().

Problem/Motivation

Implementing node access through the $query->addTag('node_access') method requires queries that do not use {node} as base table to explicitly define the base table through $query->addMetaData('base_table', table).

At the moment, while it allows modules to add the node_access tag via 'query access tag' in hook_views_data(), views does not allow passing query metadata via that same hook. This is holding up some of the list-to-views conversion issues such as #2020387: Convert "Active forum topics" block to a View, since the query node_access tag on a non-node base table causes exceptions:

Exception: Query tagged for node access but there is no node table, specify the base_table using meta data. in node_query_node_access_alter() (line 1867 of /d8/core/modules/node/node.module).

For background, see

• Document the use of metadata to indicate a base table for node access queries
• Always use query metadata to specify the node access base table
• Converting node access queries to 7.3
• SA-CORE-2011-002 - Drupal core - Access bypass

Proposed resolution

Allow modules to pass query metadata along with the 'query access tag' in hook_views_data().

Here's how this would look for the forum module:

/**
 * Implements hook_views_data().
 */
function forum_views_data() {

  $data['forum_index']['table']['group'] = t('Forum');
  $data['forum_index']['table']['base'] = array(
    'field' => 'nid',
    'title' => t('Forum content'),
    'access query tag' => 'node_access',
    'query metadata' => array('base_table' => 'forum_index'),
  );
  ...

Remaining tasks

User interface changes

None.

API changes

One more key (for example 'query metadata') added to the hook_views_data return value.