When having some tips failing it is good to know how many tips are tested and how many are modal versions. This is esp useful when having modules altering tips and thus tip count.

Files: 
CommentFileSizeAuthor
#5 drupal8.tour-module.2099471-5.patch1.22 KBclemens.tolboom
PASSED: [[SimpleTest]]: [MySQL] 59,315 pass(es).
[ View ]
#3 drupal8.tour-module.2099471-3.patch1.23 KBclemens.tolboom
PASSED: [[SimpleTest]]: [MySQL] 58,923 pass(es).
[ View ]
#1 drupal8.tour-module.2099471-1.patch1.23 KBclemens.tolboom
PASSED: [[SimpleTest]]: [MySQL] 58,661 pass(es).
[ View ]

Comments

clemens.tolboom’s picture

Status:Active» Needs review
StatusFileSize
new1.23 KB
PASSED: [[SimpleTest]]: [MySQL] 58,661 pass(es).
[ View ]
larowlan’s picture

Needs a . on end of "it's a modal" comment

clemens.tolboom’s picture

StatusFileSize
new1.23 KB
PASSED: [[SimpleTest]]: [MySQL] 58,923 pass(es).
[ View ]

Added #2.

Can we do better showing hook_tour_tips_alter kicked in? See #2017471: Multilingual tour for language section for our first implementation.

larowlan’s picture

+++ b/core/modules/tour/lib/Drupal/tour/Tests/TourTestBase.php
@@ -60,7 +62,13 @@ class TourTestBase extends WebTestBase {
+      $this->assertTrue(true, format_string('Total %total Tips tested of which %modals modal(s).', array('%total' => $total, '%modals' => $modals)));

Should use $this->pass() instead of $this->assertTrue()

clemens.tolboom’s picture

StatusFileSize
new1.22 KB
PASSED: [[SimpleTest]]: [MySQL] 59,315 pass(es).
[ View ]

@larowlan thanks

larowlan’s picture

Status:Needs review» Reviewed & tested by the community

Thanks

larowlan’s picture

Category:feature» task

Not really a feature, just a useful debug addition

Xano’s picture

Title:Report the total number and modal tips testen.» Report the total number and modal tips tests

Title fix.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

I'll take your word for it that this is helpful. :)

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.