Updated: Comment #N

Problem/Motivation

Site builders may wish to give a comment-field an administrative description to clarify it's intent to other site-builders/admin - analagous to the admin description for node types.

Proposed resolution

Add a field setting to store/record this value on the field
Display it at admin/structure/comments

Remaining tasks

Patch
Review

User interface changes

Screenshots:

API changes

None

Follow-up from #731724: Convert comment settings into a field to make them work with CMI and non-node entities.

CommentFileSizeAuthor
#10 comment-field-description-2099421..patch3.83 KBlarowlan
#10 interdiff.txt876 byteslarowlan
#10 Screenshot 2014-02-25 18.15.42.png19.34 KBlarowlan
#10 Screenshot 2014-02-25 18.15.59.png24.32 KBlarowlan
#10 Screenshot 2014-02-25 18.16.48.png17.5 KBlarowlan
#5 comment-field-description-2099421.3.patch4.43 KBlarowlan
#5 interdiff.txt1.56 KBlarowlan
#3 Screenshot 2013-11-28 18.56.38.png33 KBlarowlan
#3 Screenshot 2013-11-28 18.57.07.png44.59 KBlarowlan
#2 comment-field-description-2099421.2.patch4.3 KBlarowlan

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed » Active
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new comment-field-description-2099421.2.patch4.3 KB

Straight forward

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue summary: View changes
StatusFileSize
new Screenshot 2013-11-28 18.57.07.png44.59 KB
new Screenshot 2013-11-28 18.56.38.png33 KB

Screenshots

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

editing
admin

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new interdiff.txt1.56 KB
new comment-field-description-2099421.3.patch4.43 KB

Adds a title to the field in the settings form (doh) and makes the description column RESPONSIVE_PRIORITY_MEDIUM so hidden on mobiles.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Looks nice as addition

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

The help text on that first screenshot (form) doesn't make any sense to me. Can we come up with something better?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Hi Dries
Which help text - the 'These settings ....' or the 'Enter an administrative....'
If the former, this already exists in core, this patch only adds the second description

Lee

andypost’s picture

andypost
he/him
Primary language Russian
commented

Suppose Dries means a better description for the settings, to explain where it could be applicable

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot 2014-02-25 18.16.48.png17.5 KB
new Screenshot 2014-02-25 18.15.59.png24.32 KB
new Screenshot 2014-02-25 18.15.42.png19.34 KB
new interdiff.txt876 bytes
new comment-field-description-2099421..patch3.83 KB

New text based on how node-types do it.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

back to rtbc, #7 addressed

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Consistency++

Committed 494d469 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.