Support from Acquia helps fund testing for Drupal Acquia logo

Comments

targoo’s picture

Before patch

Screen Shot 2013-09-27 at 10.06.23.png

After patch

Screen Shot 2013-09-27 at 10.06.32.png

larowlan’s picture

Issue tags: +Needs tests

Thanks, can we add a simple test assert so this isn't lost again?

SGhosh’s picture

Tested patch in #1.

Confirming patch to work as required - helper description shows.

brahmjeet789’s picture

Issue summary: View changes
FileSize
22.03 KB
24.57 KB

#1 wprking fine, ihave tested it

brahmjeet789’s picture

Status: Needs review » Reviewed & tested by the community
larowlan’s picture

Status: Reviewed & tested by the community » Needs work

Still needs a test.

larowlan’s picture

Assigned: targoo » larowlan

adding tests

larowlan’s picture

Assigned: larowlan » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
769 bytes
769 bytes
1.28 KB

Should be fail/pass

larowlan’s picture

FileSize
479 bytes
1.48 KB

Yeah and helps if the help block is placed ;)

Status: Needs review » Needs work

The last submitted patch, 8: forum-desc-2099251.8.pass_.patch, failed testing.

jibran’s picture

Status: Needs work » Reviewed & tested by the community

So RTBC then.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice catch! That test is probably a little overkill for this, but I appreciate your thoroughness! :)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.