Follow-up from #2080537: Remove Unused local variable $output from /core/modules/forum/forum.module.
The helper description is not showing up on the forum page (admin/structure/forum)

CommentFileSizeAuthor
#9 forum-desc-2099251.9.patch1.48 KBlarowlan
#9 interdiff.txt479 byteslarowlan
#8 forum-desc-2099251.8.pass_.patch1.28 KBlarowlan
#8 forum-desc-2099251.8.fail_.patch769 byteslarowlan
#8 interdiff.txt769 byteslarowlan
#4 afterapplypatch.png24.57 KBbrahmjeet789
#4 beforepatch.png22.03 KBbrahmjeet789
#1 2099251-Missing-helper-description-forum-1.patch545 bytestargoo
#1 Screen Shot 2013-09-27 at 10.06.32.png36.71 KBtargoo
#1 Screen Shot 2013-09-27 at 10.06.23.png36.64 KBtargoo
Screen Shot 2013-09-27 at 09.50.49.png28.74 KBtargoo

Comments

targoo’s picture

targoo commented
Status: Active » Needs review
StatusFileSize
new Screen Shot 2013-09-27 at 10.06.23.png36.64 KB
new Screen Shot 2013-09-27 at 10.06.32.png36.71 KB
new 2099251-Missing-helper-description-forum-1.patch545 bytes

Before patch

Screen Shot 2013-09-27 at 10.06.23.png

After patch

Screen Shot 2013-09-27 at 10.06.32.png

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Needs tests

Thanks, can we add a simple test assert so this isn't lost again?

SGhosh’s picture

SGhosh commented

Tested patch in #1.

Confirming patch to work as required - helper description shows.

brahmjeet789’s picture

brahmjeet789 commented
Issue summary: View changes
StatusFileSize
new beforepatch.png22.03 KB
new afterapplypatch.png24.57 KB

#1 wprking fine, ihave tested it

brahmjeet789’s picture

brahmjeet789 commented
Status: Needs review » Reviewed & tested by the community
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs work

Still needs a test.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: targoo » larowlan

adding tests

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: larowlan » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new interdiff.txt769 bytes
new forum-desc-2099251.8.fail_.patch769 bytes
new forum-desc-2099251.8.pass_.patch1.28 KB

Should be fail/pass

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new interdiff.txt479 bytes
new forum-desc-2099251.9.patch1.48 KB

Yeah and helps if the help block is placed ;)

Status: Needs review » Needs work

The last submitted patch, 8: forum-desc-2099251.8.pass_.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community

So RTBC then.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch! That test is probably a little overkill for this, but I appreciate your thoroughness! :)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.