Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow-up from #2080537: Remove Unused local variable $output from /core/modules/forum/forum.module.
The helper description is not showing up on the forum page (admin/structure/forum)
Comment | File | Size | Author |
---|---|---|---|
#9 | forum-desc-2099251.9.patch | 1.48 KB | larowlan |
#9 | interdiff.txt | 479 bytes | larowlan |
#8 | forum-desc-2099251.8.pass_.patch | 1.28 KB | larowlan |
#8 | forum-desc-2099251.8.fail_.patch | 769 bytes | larowlan |
#8 | interdiff.txt | 769 bytes | larowlan |
Comments
Comment #1
targoo CreditAttribution: targoo commentedBefore patch
After patch
Comment #2
larowlanThanks, can we add a simple test assert so this isn't lost again?
Comment #3
SGhosh CreditAttribution: SGhosh commentedTested patch in #1.
Confirming patch to work as required - helper description shows.
Comment #4
brahmjeet789 CreditAttribution: brahmjeet789 commented#1 wprking fine, ihave tested it
Comment #5
brahmjeet789 CreditAttribution: brahmjeet789 commentedComment #6
larowlanStill needs a test.
Comment #7
larowlanadding tests
Comment #8
larowlanShould be fail/pass
Comment #9
larowlanYeah and helps if the help block is placed ;)
Comment #11
jibranSo RTBC then.
Comment #12
webchickNice catch! That test is probably a little overkill for this, but I appreciate your thoroughness! :)
Committed and pushed to 8.x. Thanks!