I think capitalizing the status, priority, category, etc. is fine since it is a new standard in D7, but now components in a list like https://git7site.devdrupal.org/project/issues/drupal look very weird in comparison. We should consider a CSS transformation to make these match, too.

CommentFileSizeAuthor
#9 2097931-capitalize-component.patch477 bytesjthorson

Comments

jthorson’s picture

jthorson commented
Status: Active » Needs review
Issue tags: +drupal.org D7

Tagging. Consistency is good.

helmo’s picture

helmo commented

@webchick: can you link a page where status, priority or category are capitalized?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Yes, the link in the original post is such a link. You'll notice the values in each column all start with a capital letter, except for the "Component" values.

jthorson’s picture

jthorson commented
Assigned: Unassigned » jthorson
jthorson’s picture

jthorson commented

Taking this

helmo’s picture

helmo commented

Ah, I see.

As components are user configurable per project I guess this would involve updating this for the drupal core project in the database.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Yeah. Not sure it's worth it, TBH — I categorized this as "minor" for a reason. :) But if there's an existing migration function around that ucfirst()s things that could be applied to the component values, it'd help with consistency.

jthorson’s picture

jthorson commented
Project: [Archive] Drupal.org D7 upgrade QA » Project issue tracking
Version: » 7.x-2.x-dev

Patch does it with a css text-transform ... but yes, we should consider whether we actually want to automatically capitalize the first letter of all components.

jthorson’s picture

jthorson commented
StatusFileSize
new 2097931-capitalize-component.patch477 bytes

Bah ... drupal.org likes losing patch files when you change the project assignment in the same edit. :(

tvn’s picture

tvn commented

This is *really* not a launch blocker. Since there is a patch already, let's commit it. But anything else should be done post launch.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Committed.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Awesome, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

dww’s picture

dww
we/he/they
commented

Note: people are complaining about this and there's a call to revert this patch:

#2125307: Change component fields back to lower case