Image toolkits can embed configuration forms in the main image settings form. This should be done using PluginFormInterface, however. See #2095289: Make getEditableConfigNames() public and use it in config_translation

CommentFileSizeAuthor
#11 image-2096703-11.patch17.7 KBtim.plunkett
#11 interdiff.txt5.65 KBtim.plunkett
#8 2096703-toolkit_form-8.patch17.75 KBmondrake
#8 interdiff_6-8.txt9.8 KBmondrake
#6 2096703-toolkit_form-6.patch12.22 KBmondrake
#5 2096703-toolkit_form-5.patch11.38 KBmondrake
#4 2096703-toolkit_form-4.patch11.06 KBmondrake
#2 2096703-toolkit_form-2.patch11.3 KBmondrake

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Component: search.module » image.module

I don't think this is a search.module issue? maybe not image.module either, but not search.module for sure...

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Image toolkits should use PluginFormInterface » Image toolkits should use PluginFormInterface and ContainerFactoryPluginInterface
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2096703-toolkit_form-2.patch11.3 KB

I think besides PluginFormInterface they should also use ContainerFactoryPluginInterface to inject services where needed.

Patch here introduces both + a test for form validation.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Component: image.module » image system
mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 2096703-toolkit_form-4.patch11.06 KB

Reroll for #2247991: [May 27] Move all module code from …/lib/Drupal/… to …/src/… for PSR-4

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 2096703-toolkit_form-5.patch11.38 KB

Reroll.

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 2096703-toolkit_form-6.patch12.22 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 6: 2096703-toolkit_form-6.patch, failed testing.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_6-8.txt9.8 KB
new 2096703-toolkit_form-8.patch17.75 KB

Cleaned up.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Parent issue: » #2105863: [meta] Images, toolkits and operations
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Priority: Normal » Major
Issue tags: +Plugin system

I didn't know about this issue, there was also #2326721: EditorPluginInterface should extend PluginFormInterface. I'll remove the image parts from that issue.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new interdiff.txt5.65 KB
new image-2096703-11.patch17.7 KB

Rerolled, and added in some tweaks and fixes.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Looking good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 34246f4 and pushed to 8.0.x. Thanks!

  • alexpott committed 34246f4 on 8.0.x 
    Issue #2096703 by mondrake, tim.plunkett | tstoeckler: Image toolkits...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.