I am not really sure this is the right issue queue, however, here I go.

In my account preferences in drupal.org, I am subscribed to all project issues for my own issues (and for a few modules, I am subscribed for all of them). Yesterday, I filed two new issues for the Role contact module (here and here), however, I have not received any e-mails or status updates for those two issues.

I guess there's something wrong here.

CommentFileSizeAuthor
#19 209507_pi_fix_subscribe_15.patch719 bytesaclight

Comments

aclight’s picture

Status: Active » Postponed (maintainer needs more info)

Did you change your subscription settings before the Role contact project was created? If so, that's the problem. The code that handles subscriptions actually subscribes you to each project that you select at the time you edit the settings. If a project doesn't exist at the time you edit your settings, you won't be subscribed to it later when it is created. You need to periodically go back and edit your settings and click the own issues button for all projects and save.

So, to check this, just view your subscription settings right now. I'm guessing that for the role contact module, it will show you as having no subscriptions. If that's the case, then this is a duplicate of http://drupal.org/node/177318 and if would be great if you could set the status to show that. If that's not the case this might be a separate issue, but someone with drupal db access would probably need to check this out to see if the db shows you as being subscribed or not.

GoofyX’s picture

I just checked the subscription settings. The Role contact module is set to 'Own issues'. There are of course other modules that are set to 'None'. So, I guess this is a bug of some kind.

And no, I had not changed the subscriptions before filing the issues. The reason I checked the subscription settings is the e-mail problem I'm describing here, just to confirm that the correct settings are set.

Update: I just got an e-mail for this specific comment...

GoofyX’s picture

Please, any idea about this? Am I the only one experiencing this behaviour?

GoofyX’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

Right. Now I get e-mail notifications.

I will mark this closed...

GoofyX’s picture

Status: Closed (fixed) » Active

Hm... Same behaviour again. This time for the Event module (issue is here).

hunmonk’s picture

Status: Active » Postponed (maintainer needs more info)

nobody else is reporting this, and we can't replicate it.

GoofyX’s picture

It seems to be ok now. I will reopen the issue if this happens again.

GoofyX’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

Forgot to change status.

GoofyX’s picture

Status: Closed (fixed) » Active

I'm reopening this issue, because it happened again. This time, I think I have found a pattern this occurs.

It seems that when I create an issue, I always do not get the first message for it (the node without the comments) and maybe a couple of the first two or three comments. This happened again when I opened an issue for Drupal. I did not get the first message for the issue, plus with the messages up to (including) #3. I got two messages for #4 and #5. For the current issue, I checked my mails and saw that I did not get the first message and the message for comment #1.

Could this help?

aclight’s picture

Status: Active » Postponed (maintainer needs more info)

My gut feeling is that this is not a problem with the project issues module itself.

The only time I have seen this kind of behavior is when I thought I was subscribed to get issues (all or my own) from a project but wasn't actually subscribed to that project.

It could also be that the mail is getting lost/discarded/removed from plain sight somewhere along the way due to a spam filter or some other kind of filter. I have email from my d.o account go to gmail, and I haven't had any problems with them putting issue emails in my spam folder.

As hunmonk said above, you seem to be the only one reporting this problem.

Please check your mail applications settings as well as those of your ISP or upstream provider to see if somehow things are getting lost along the way. If as far as you can tell things there are good then please move this issue into the D.o infrastructure queue, as this will need to be investigated by someone with admin access to the d.o servers.

GoofyX’s picture

aclight, thanks for the answer.

I am using the same e-mail account to get the messages as the one I use with the Drupal mailing lists (development, translations, document, support, themes), where I seem not to have missed a single message. Of course, I was subscribed to the Drupal project (own issues) for a long time now.

Thanks, anyway.

aclight’s picture

Status: Postponed (maintainer needs more info) » Active
aclight’s picture

Ok, I can confirm that this is indeed happening.

For some time now, I have been subscribed to "own issues" for the Views issue queue.

A week ago, I created 4 new issues in that queue.

Of those 4 issues, I have not received *any* of the follow up email notifications for 3 of the issues:
#254325: Include a null argument
#254347: WSOD when viewing a page (or views preview of a page) with an attachment attached
#254340: Add and rearrange buttons are not properly aligned in Safari

For the 4th issue, I *did* receive all follow up email notifications:
#254350: Validator select box and options sometimes cannot be selected in FF

I have searched through gmail (including my spam and trash folders) for signs of these first three issues and I got neither the original issue nor any followups sent to me.

That being said, I can't think of why this would be happening.

As a point of information, all 4 of these issues are correctly listed on my "My issues" page at http://drupal.org/project/issues/user

aclight’s picture

I believe I've uncovered the problem here (or at least part of the problem).

Take a look at http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/project_iss... (lines 224-227).

We're now putting the uid of the person the issue is assigned to, not authored by, in the list of uids which will eventually be potential email recipients.

There are some related changes in lines 277-283.

It looks to me like before this patch was committed, if you were subscribed to "my own issues" on a particular project, you got an email in any of the following cases:
1. You created the issue
2. You commented on the issue
3. You were assigned to the issue when a comment was created.

Now, it seems that 2 and 3 still happen, but #1 does not.

I'm about to head out now and don't have time to roll a patch, but let me know if I'm overlooking something here.

aclight’s picture

Title: Not getting e-mail for own issues » REGRESSION: Not getting e-mail for own issues
Version: 5.x-1.2 » 5.x-2.x-dev
Assigned: Unassigned » aclight
Priority: Normal » Critical
Status: Active » Needs review

The attached patch fixes the fact that the original creator of an issue was not getting email notifications of comments on an issue he created unless he had also commented on that same issue. This happens in the case where the user selects to receive "own issues" on the subscriptions page.

I'm marking this as critical because of the fact that this behavior is a regression and directly impacts users who primarily monitor the issue queues via email.

The patch also keeps the behavior of the user an issue is assigned to gets the email notification if the user is subscribed to the queue.

dww’s picture

Status: Needs review » Needs work

Nice detective work, thanks! Now, where's that patch? ;)

aclight’s picture

The patch got eaten by the other issue, which probably hasn't been created yet, that sometimes causes attachments to not actually be submitted. I'm pretty sure I attached the patch.

But in any case, i'll upload it tonight when I get home.

GoofyX’s picture

Nice catch aclight! I'm glad this has been found. Behavior confirmed as you explain in #260355: Timezone handling settings not saved (I only got the e-mail for the first comment and not the actual issue).

aclight’s picture

StatusFileSize
new719 bytes

Hopefully the patch will stick this time.

aclight’s picture

Status: Needs work » Needs review
dww’s picture

Status: Needs review » Fixed

Thanks! Reviewed, committed to DRUAPL-5--2 and HEAD, and deployed on d.o.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.