Follow-up from #2094297: Fieldsets are unstyled.

CommentFileSizeAuthor
#18 bootstrap-vertical-tabs-only-remove-legend-panel-heading-2094409-17.patch373 bytesvalkum
#15 bootstrap-vertical-tabs-only-remove-legend-panel-heading--0.patch377 bytesvalkum
#8 vertical_tabs.jpg184.01 KBmarkhalliwell
#6 vertical_tabs_theme_for_bs3-2094409-6.patch7.73 KBdenes.szabo

Comments

markhalliwell’s picture

markhalliwell
Primary language English
commented

It appears they removed the left tabs in BS3. I found some CSS that we could implement in the overrides.less file: http://stackoverflow.com/questions/18432577/stacked-tabs-in-bootstrap-3

denes.szabo’s picture

denes.szabo commented
Assigned: Unassigned » denes.szabo

I started working on it…

markhalliwell’s picture

markhalliwell
Primary language English
commented

Thanks @Denes.Szabo!

markhalliwell’s picture

markhalliwell
Primary language English
commented

You will need to re-roll/rebase if you've done any work on this yet. There have been changes to the fieldset/panel replacement markup.

markhalliwell’s picture

markhalliwell
Primary language English
commented

Also keep in mind a solution must also include the ability for vertical tab summaries to be allowed to update.

denes.szabo’s picture

denes.szabo commented
StatusFileSize
new vertical_tabs_theme_for_bs3-2094409-6.patch7.73 KB

First iteration. We are talking about it on irc on #drupal-bootstrap.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: denes.szabo » markhalliwell
Status: Active » Needs work

@Denes.Szabo thanks! This is awesome work! Great job! I'll have to dive in manually to seeing how things are lookin. I'll submit a patch later tonight.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Fixed
StatusFileSize
new vertical_tabs.jpg184.01 KB

Thanks @Denes.Szabo!

Committed 0d3a21e to 7.x-3.x.

I was going to upload a patch, but there was a TON of work that I needed to do to get it stable. I've gone ahead and committed it. Please feel free to open new issues for any regressions that may creep up.

Committed 9f3ce63 to 7.x-3.x.

vertical_tabs.jpg

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Fixed » Needs work

Hmm... I'm not really happy with this. I had to put in a TON of JS overrides to get all the core stuff working because they were explicitly looking for fieldset. I suspect we need to figure out a way to work with fieldsets.

robloach’s picture

robloach
he/him
commented

What if we were to completely remove the "Vertical" in Vertical Tabs and switched to straight up Bootstrap Tabs? Would keep it as mobile-friendly as possible, while keeping with what Bootstrap provides.

[EDIT] Don't mind me, carry on. What are you suggesting here?

brian_ak’s picture

brian_ak commented

This causes the vertical tabs to render on node/add, node/edit pages regardless of permissions, so users without appropriate permissions see the tab links with empty tab content as opposed to not seeing tabs at all

markhalliwell’s picture

markhalliwell
Primary language English
commented
Category: task » bug

This is actually a bug now.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Fixed

@brian_ak, this should be fixed now. If not, please open a new issue.

Committed b5ee602 to 7.x-3.x.
- Fixed bootstrap panels to use 'fieldset' tags instead. Override the single vertical-tabs.js file to work with Bootstrap tab plugin and removed all the other file overrides.
- Changed the theme settings pages a bit.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 7.x-3.x-dev » 7.x-3.0-rc1
valkum’s picture

valkum commented
StatusFileSize
new bootstrap-vertical-tabs-only-remove-legend-panel-heading--0.patch377 bytes

We only hide the legend.panel-heading and not all panel-heading.
This way we can insert panels inside '#prefix's ATM the panel-heading there would be removed. But for tableselect panels are very useful.
Attached is a patch.

valkum’s picture

valkum commented
Status: Fixed » Needs review
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Needs work

Actually I think .tab-pane > .panel-heading would be better here.

valkum’s picture

valkum commented
Status: Needs work » Needs review
StatusFileSize
new bootstrap-vertical-tabs-only-remove-legend-panel-heading-2094409-17.patch373 bytes
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed

Thanks @valkum!

Committed eea9a1e to 7.x-3.x.
Committed 7b53e28 to 7.x-3.x.

Automatically closed -- issue fixed for 2 weeks with no activity.