I'm not a native English speaker, but I've always found the text on the Appearance page for setting a theme as the default as unnecessarily terse. "Enable and set default" and "Set default" could just as well be "Enable and set as default" and "Set as default." I came across this while translating Drupal core to Norwegian and thinking the Norwegian translation was wrong.

I've attached a patch and a screenshot of the relevant part of the Appearance page with the patch applied.

CommentFileSizeAuthor
#4 drupal-8-theme-ui-text-2093477-3.patch3.1 KBTor Arne Thune
AppearancePageAfter.png68.85 KBTor Arne Thune
drupal-8-theme-ui-text.patch2.36 KBTor Arne Thune
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Status: Active » Needs review
EMHmark7’s picture

EMHmark7 CreditAttribution: EMHmark7 commented

Tested against most recent D8 dev. It does not accept the patch
It needs reroll.

EMHmark7’s picture

EMHmark7 CreditAttribution: EMHmark7 commented
Issue summary: View changes
Status: Needs review » Needs work
Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Status: Needs work » Needs review
FileSize
drupal-8-theme-ui-text-2093477-3.patch3.1 KB

You're absolutely right.

unknownterritory’s picture

unknownterritory CreditAttribution: unknownterritory commented
Status: Needs review » Reviewed & tested by the community

I agree with the author: the English used in the patch is more sound and explicit.
I've also tested the patch, which works perfectly.
I've also searched for other similar strings on the whole code and couldn't find any other instances, so the patch covers all needs.
I'm changing the status to reviewed and tested by the community.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Usability

Hm. Assigning to the UX team for review, since I believe this terse-ness was done on purpose when we were re-styling UX text. But the claim that it's breaking UX for translators seems worth discussing.

xenophyle’s picture

xenophyle CreditAttribution: xenophyle commented

Yay, I'm really glad about this patch. The wording has bothered me for a long time.

yoroy’s picture

yoroy CreditAttribution: yoroy commented

drupal-8-theme-ui-text.patch queued for re-testing.

The last submitted patch, drupal-8-theme-ui-text.patch, failed testing.

yoroy’s picture

yoroy CreditAttribution: yoroy commented

Retested the wrong patch, didn't I…
I agree the current wording is too terse, the patch makes perfect sense to me.

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Status: Needs review » Reviewed & tested by the community

Great, thanks for your input! Back to RTBC for webchick or another core committer I suppose?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Great, thanks for checking!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.