Postponed on #2041885: Move HTTP basic authentication provider to a separate module.

Now that we have a new "Web Services" package for HTTP basic auth module we should use it for the other web service related modules as well.

CommentFileSizeAuthor
#6 Capture.PNG9.22 KBgarphy
#5 web-services-package-2092817-5.patch1.86 KBklausi
#3 WebServices.png27.13 KBStuartJNCC
#1 web-services-package-2092817-1.patch1.88 KBklausi

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: Move REST, serialization and HAL to the web services package » Move REST, serialization and HAL to the web services package + CHANGELOG.txt entry
Status: Postponed » Needs review
StatusFileSize
new web-services-package-2092817-1.patch1.88 KB

We can add a changelog entry here as well, while we are at it.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

I like this RTBC for me let's see what @Crell has to say about this.

StuartJNCC’s picture

StuartJNCC commented
StatusFileSize
new WebServices.png27.13 KB

If I apply the patch in #1, I get two groups called "WEB SERVICES" in the modules list:

web services groups

The problem seems to be that in basic_auth.info.yml the line is:

package: Web services

whilst those added by the patch are:

+package: Web Services

i.e. capital "S" on "Services". Easy to fix the patch, but should a minor case difference like this matter when the package names are forced into upper-case anyway before display?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Needs work

Oh. That looks silly. :)

The standard is "Capitalize only the first word."

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Needs review
StatusFileSize
new web-services-package-2092817-5.patch1.86 KB

Right, fixed that. Also moved the CHANGELOG fixes to the bottom.

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
StatusFileSize
new Capture.PNG9.22 KB

#5 is OK for me.
Screenshot

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
Status: Needs review » Reviewed & tested by the community

I think that's an easy one.

StuartJNCC’s picture

StuartJNCC commented

Opened a new issue #2099299: Package labels in module .info.yml files are case sensitive for what I would consider to be the bug revealed here, that differences in case amongst the package labels cause the modules to be listed under separate, but identically named groups.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.