This issue is part of the task to update the hook_help texts of the Drupal 8 modules:
#1908570: [meta] Update or create hook_help() texts for D8 core modules

- review / write the hook_help text according to help guidelines

#7 interdiff.txt802 bytesbatigolix
#7 update-hook-help-forum-2091455-7.patch3.59 KBbatigolix
PASSED: [[SimpleTest]]: [MySQL] 59,895 pass(es). View
#6 interdiff-2091455-2-6.txt2.1 KBInternetDevels
#6 update-hook-help-forum-2091455-6.patch3.58 KBInternetDevels
PASSED: [[SimpleTest]]: [MySQL] 59,827 pass(es). View


berkas1’s picture

Taking it - Drupalcon Prague

berkas1’s picture

Status: Active » Needs review
3.52 KB
PASSED: [[SimpleTest]]: [MySQL] 58,634 pass(es). View
petrpo’s picture

Manualy patched module forum and all links are working right.

jhodgdon’s picture

Status: Needs review » Needs work

Thanks for the patch and the testing!

Looking over this help as a whole, it doesn't really follow our guidelines on , so the help for this module needs some more work.

a) The "For more information..." line is not our standard wording/format.

b) The Uses topics should all have headers with -ing verbs.

Other than that, I think it looks good.

berkas1’s picture

Assigned: Unassigned » berkas1

Thanks, I'll send patch ASAP

InternetDevels’s picture

Issue summary: View changes
Status: Needs work » Needs review
Parent issue: » #1908570: [meta] Update or create hook_help() texts for D8 core modules
3.58 KB
PASSED: [[SimpleTest]]: [MySQL] 59,827 pass(es). View
2.1 KB

Added patch.

batigolix’s picture

3.59 KB
PASSED: [[SimpleTest]]: [MySQL] 59,895 pass(es). View
802 bytes

I verified the patch in #6:

- Verify that all the links work --> Okay
- Verify that all mentions of pages/text within the UI match what is seen in the UI --> Okay
- Verify that the formatting is OK. --> Okay

I just found the link to d.o should be https. Attached patch fixes that

batigolix’s picture

Assigned: berkas1 » Unassigned
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks like this one is ready to commit! We're in the middle of a "only commit critical and major issues" week, so I'll get it committed on the 23rd or so.

jhodgdon’s picture

I'm being extra careful about commit conflicts lately, and there is an issue tagged "avoid commit conflicts" that touches this file. So I plan to wait to commit this until
#1996238: Replace hook_library_info() by *.libraries.yml file
is resolved. Sorry for the delay!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

#1996238: Replace hook_library_info() by *.libraries.yml file is postponed. Committed d78587e and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.