Fulltext Filter does not match surname

This came up in https://drupal.org/node/1369618#comment-5542738 to ensure that search for cd didn't match abcd, but matched cdef.

SELECT CONCAT('"', (LOWER(CONCAT(' ', COALESCE(field_data_field_name_test.field_name_test_title, ''), ' ', COALESCE(field_data_field_name_test.field_name_test_given, ''), ' ', COALESCE(field_data_field_name_test.field_name_test_middle, ''), ' ', COALESCE(field_data_field_name_test.field_name_test_family, ''), ' ', COALESCE(field_data_field_name_test.field_name_test_generational, ''), ' ', COALESCE(field_data_field_name_test.field_name_test_credentials, '')))), '"') FROM `field_data_field_name_test` 

produces " john doe ", so both '% doe%' and '%doe%' would match this string. Are you sure that you didn't have both first and second names in the search? ie: "%john doe%" != " john doe "

This looks like a duplicate of #2536618: Extra space added when searching with CONTAINS in Views Exposed Filters., except the patch in #2536618-2: Extra space added when searching with CONTAINS in Views Exposed Filters. fixes the issue in both the "contains" and the "contains word" filters.

Is it worth closing this issue, or #2536618?

I'll close this as a duplicate of #2536618: Extra space added when searching with CONTAINS in Views Exposed Filters. because the other has more details and fixes the problem more completely. But I'd suggest crediting @webflo on the other one.

That or @mparker17 could you post your patches here and update the IS?

This looks like a quick fix.

@joelpittet, not sure I understand what you want me to do in #4... judging by your comments in #5 and your request for credit for @webflo in #2090789-5: Fulltext Filter does not match surname, is it safe for me to assume that there is nothing I need to do?

@mparker17 since you replied, could you move your code here and close your issue? That would be the easiest

Sure thing!

Uploading patch from #2536618-2: Extra space added when searching with CONTAINS in Views Exposed Filters..

To make things easier to understand, I will fix \name_handler_filter_name_fulltext::op_word() inside includes/name_handler_filter_name_fulltext.inc in a separate patch, with interdiff.

Oh, turns out the change to op_word() was already done: I think the diff file didn't make that clear in the hunk headings. So this is ready to go.

Still RTBC, thank you @mparker17, that should make it easier to credit you both.

I just tried repeating again without issue. As per #4 above, the query generated is:

(LOWER(CONCAT(' ', COALESCE(field_data_field_multiple_names.field_multiple_names_title, ''), ' ', COALESCE(field_data_field_multiple_names.field_multiple_names_given, ''), ' ', COALESCE(field_data_field_multiple_names.field_multiple_names_middle, ''), ' ', COALESCE(field_data_field_multiple_names.field_multiple_names_family, ''), ' ', COALESCE(field_data_field_multiple_names.field_multiple_names_generational, ''), ' ', COALESCE(field_data_field_multiple_names.field_multiple_names_credentials, ''))) LIKE '% test%') ))

For John Doe, searching Doe, this is: '  john  doe ' LIKE '% doe%' which matches, as would John.

Am I missing something here?

Thanks for having a look @Alan D. We'll try again without the patch, if it always concatenates all the pieces and whitespace on both ends then there shouldn't be a problem.

I couldn't reproduce this with the patch removed so I think it has been fixed for us.

Thanks for checking. :)