In a conditional action "Send an order email regarding roles", if I have in the "Recipients" text area either a blank line or a token that evaluates to a blank line, uc_roles_action_user_email() tries to send to this blank email address which produces errors.

Shouldn't there be a test as we build the $recipients array to not add blank email addresses?

CommentFileSizeAuthor
#1 2090221-uc_roles-empty-email.patch1.07 KBlongwave

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 2090221-uc_roles-empty-email.patch1.07 KB

Please test the attached patch.

dpearcefl’s picture

dpearcefl commented

Preciously what I tried and it worked.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Committed to 6.x-2.x, ported and committed to 7.x-3.x as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.