The following notice shows up when the comment module is disabled.

Notice: Undefined index: comment in editableviews_views_data_alter() (line 102 of public_html/sites/all/modules/contrib/editableviews/editableviews.views.inc).

The patch eliminates it

Files: 
CommentFileSizeAuthor
#4 0001-remove-warnings-when-comment-module-is-disabled.patch1.19 KBdrone.ah
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View
0001-remove-warnings-when-comment-module-is-disabled.patch1.24 KBdrone.ah
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

Comments

Paul B’s picture

Priority: Minor » Normal
Status: Active » Needs review
Paul B’s picture

Status: Needs review » Reviewed & tested by the community

The patch works for me.

joachim’s picture

Status: Reviewed & tested by the community » Needs work

Thanks for the patch! I guess this is caused by field instances that haven't been deleted when a module is disabled.

Just a few tweaks to make it more readable:

It's actually fine to check all the levels of the array at once. So we only need the second isset() as it will check for both array levels.

Also, patch has a whitespace change that's crept in.

drone.ah’s picture

Issue summary: View changes
FileSize
1.19 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

I've removed the redundant isset statement but I can't find the whitespace error... :-/ can you be more specific?

Paul B’s picture

Status: Needs work » Needs review
joachim’s picture

Status: Needs review » Fixed

Committed. Thanks!

git commit -m "Issue #2089521 by drone.ah: Fixed notice for fields on missing entity types." --author="drone.ah "

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.