Quick edit option appears twice on contextual links menu (see attachment).

Steps to reproduce

  1. Create and publish Basic page using Full HTML content type
  2. Click on contextual edit link
#8 2089397-8.patch1.31 KBWim Leers
PASSED: [[SimpleTest]]: [MySQL] 58,915 pass(es). View
#8 interdiff.txt1.27 KBWim Leers
#7 2089397-7.patch1.24 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 58,791 pass(es). View
Zrzut ekranu z 2013-09-15 11:58:50.png119.3 KBmwysinski
Members fund testing for the Drupal project. Drupal Association Learn more


webchick’s picture

Issue tags: +Spark

Huh. Well that is silly.

Wim Leers’s picture

Reproduced! The bizarre thing is that this *only* happens to "basic page" nodes, not to "article" nodes. It's reliably reproducable, not just after having created a "basic page" node, but also when reloading it. It only happens on the full node page, not on the frontpage where the teaser view mode of the node is displayed.

Similar symptoms to #2014893: Multiple "quick edit" links inserted into the contextual links when an field is edited and saved., but completely different steps to reproduce.

Much thanks for reporting!

sidharthap’s picture

Reproduced! This only happens to "basic page" nodes.

joachim’s picture

This happens to article nodes too when viewed on a full page.

Wim Leers’s picture

#3: indeed.
#4: I cant reproduce that.

swentel’s picture

Jesse's patch on the other issue (#12) fixes this -

swentel’s picture

Status: Active » Needs review
1.24 KB
PASSED: [[SimpleTest]]: [MySQL] 58,791 pass(es). View

Moving over that patch here.

Wim Leers’s picture

Assigned: Unassigned » jessebeach
Status: Needs review » Reviewed & tested by the community
Issue tags: +quickfix, +sprint
1.27 KB
1.31 KB
PASSED: [[SimpleTest]]: [MySQL] 58,915 pass(es). View

Thanks, swentel, you beat me to it :)

I tested this thoroughly manually, in many scenarios, and it definitely solves the problem.

Committer, please give commit credit to jessebeach as well, she's the one who actually rolled the patch in #7!

Tiny reroll, just to fix docs nitpicks.

P.S.: This will conflict with #1993894: Contextual quick edit toggle should be a <a role="button"> not a <a> because it tracks on/off state.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Wow, great sluething!!

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Issue tags: -sprint

Thanks! :)

Automatically closed -- issue fixed for 2 weeks with no activity.