I guess we should exclude the feature that is going to be re-created from the list of its possible dependencies.
It is a confusion and would lead to unexpected behavior (the problems with enabling/disabling/installing/uninstalling).
Reproducing is simple: just visit admin/structure/features/{feature_name}/recreate for any existing feature - you will see that "Dependencies" includes the feature itself as unchecked possible dependency.

Files: 
CommentFileSizeAuthor
#11 clean_dependency_on_feature_prepopulate-2089113-11.patch619 bytesdiego21
#4 2089113-features_export_options_depedency-3.patch6.32 KBhefox
PASSED: [[SimpleTest]]: [MySQL] 45 pass(es).
[ View ]

Comments

mpotter’s picture

Status:Active» Postponed (maintainer needs more info)

I am not seeing this on any of my test sites. Are you sure it's not something special to your feature or that maybe you have another contrib module messing this up? Otherwise post a specific example of a feature that has this problem on a clean Drupal site.

hefox’s picture

hefox’s picture

Status:Postponed (maintainer needs more info)» Needs review
StatusFileSize
new6.32 KB
PASSED: [[SimpleTest]]: [MySQL] 45 pass(es).
[ View ]

with tests

mpotter’s picture

Status:Needs review» Fixed

Committed to 69df8e1 (and fixed 2 whitespace errors in patch)

mpotter’s picture

Priority:Minor» Normal

This patch actually causes issues with Entity API by changing the interface of the hook_features_export_options() function. I think this needs to be reverted and a better solution found. I'd rather not break compatibility with other modules this close to a Features 2.0 release even if Entity API shouldn't technically be adding it's own arguments to our API functions. See #2104245: Error - Unsupported operand types in sites/all/modules/entity/entity.features.inc.

mpotter’s picture

Status:Fixed» Needs work

So I misunderstood the original problem. I thought the feature itself was being checked automatically. The fact that it is listed as a possible dependency makes this a much less serious issue. Definitely going to revert this given the issue with Entity API. Let's try to find a different approach for this issue.

mpotter’s picture

Priority:Normal» Minor
hefox’s picture

There's a function that is being called during depedencies_features_export that should be called at the end instead that does various cleanup

edit: ignore this comment, was thinking of a different issue

mpotter’s picture

Priority:Normal» Minor
Status:Needs work» Postponed

Postponing this until Features 2.1 and after Entity API has released a fix so this doesn't break in the future.

diego21’s picture

Could this be a solution to this issue?

Thanks :-)