Hi,

I have two languages (fr, en). I translate atom action links (Edit, View, Delete) for both languages. I empty caches and display atom library list, titles are well translated. I switch to other language and titles's translation correspond to the other language...

In case of multilingual site, defining the title translation of atom action links in hook_scald_actions leads to this problem. Because result of hook_scald_actions is stored in cache.

I propose to call t() during action links build in scald_atom_user_build_actions_links.

Thanks,

CommentFileSizeAuthor
#6 scald-2088245-locale-6-test-only-will-fail.patch2.55 KBjcisio
#6 scald-2088245-locale-6-all.patch5.01 KBjcisio
#5 scald-2088245-locale-5.patch2.46 KBjcisio
#1 2088245_unexpected_atom_action_links_title_translation.patch2.37 KBdDoak

Comments

dDoak’s picture

dDoak commented
StatusFileSize
new 2088245_unexpected_atom_action_links_title_translation.patch2.37 KB

see attached patch

jcisio’s picture

jcisio commented
Status: Active » Needs review
jcisio’s picture

jcisio commented

Also I think we might want to add some tests here.

Status: Needs review » Needs work

The last submitted patch, 2088245_unexpected_atom_action_links_title_translation.patch, failed testing.

jcisio’s picture

jcisio commented
Status: Needs work » Needs review
StatusFileSize
new scald-2088245-locale-5.patch2.46 KB

Failed because patch was created with svn (and against an old version). Reformat patch #1 for git. I'm trying with a test, too.

jcisio’s picture

jcisio commented
StatusFileSize
new scald-2088245-locale-6-all.patch5.01 KB
new scald-2088245-locale-6-test-only-will-fail.patch2.55 KB

The first patch is test only. It should fail. The second is test + fix, it should (hopefully) pass.

jcisio’s picture

jcisio commented
Version: 7.x-1.1 » 7.x-1.x-dev

Also I think while it is simpler to add langcode into cache key, it makes more sense to use non translated text in the info hook. The drawback is we don't have those strings available at localize.drupal.org. But let's see if tests pass.

Status: Needs review » Needs work

The last submitted patch, scald-2088245-locale-6-all.patch, failed testing.

jcisio’s picture

jcisio commented
Title: Unexpected atom action links's title translation » Unexpected action/context/player/... translation
Status: Needs work » Fixed

Failed because of trailing new line, I think. It failed locally too, because not every place are replaced with t(). However I figured that the bug is bigger as it affects also context name/description, player name/description etc. So the easiest way is to add langcode into cache key. Committed 5553834 and pushed. Tests pass on local.

Thanks for reporting.

jcisio’s picture

jcisio commented

I should have done a full test before committing it. Two tests in ScaldBaseTest that I didn't run failed. Fixed with 2841703 now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.