Convert language_negotiation_configure_form() to the new form interface

I'll take a crack at this in the morning!

First pass

With whitespace fixes dreditor hinted at.

Sorry, one final niggling whitespace fix.

This patch backs off the Local Tasks changeover as that's still in flux and was causing test failures.

The patch has two failures left that I can't figure out. Apparently, somehow, my changes to the language negotiation form controller cause the site to redirect incorrectly after the a different default language is selected on the regional settings page. It's not clear how changes to this route and controller are affecting that one.

Open to any ideas about these failures.

jibran - thanks for updating the status.

It was inexplicably failing tests; now it works! Must have been a bad test or something that got fixed...

1. +++ b/core/modules/language/lib/Drupal/language/Form/NegotiationConfigureForm.php
   @@ -0,0 +1,241 @@
   +   * Implements \Drupal\Core\Form\FormInterface::getFormID().
   ...
   +   * Implements \Drupal\Core\Form\FormInterface::buildForm().
   ...
   +   * Implements \Drupal\Core\Form\FormInterface::submitForm().
   

   @inheritdoc

2. +++ b/core/modules/language/lib/Drupal/language/Form/NegotiationConfigureForm.php
   @@ -0,0 +1,241 @@
   +    $configurable = \Drupal::config('system.language.types')->get('configurable');
   ...
   +    $stored_values = \Drupal::config('system.language.types')->get('configurable');
   

   Isn't there $this->config() available?

3. +++ b/core/modules/language/lib/Drupal/language/Form/NegotiationConfigureForm.php
   @@ -0,0 +1,241 @@
   +    // Update non-configurable language types and the related language negotiation
   +    // configuration.
   ...
   +      // If there is an active language switcher for a language type that has been
   +      // made not configurable, deactivate it first.
   

   >80 chars.

4. +++ b/core/modules/language/lib/Drupal/language/Form/NegotiationConfigureForm.php
   @@ -0,0 +1,241 @@
   +      \Drupal::service('plugin.manager.block')->clearCachedDefinitions();
   

   Is there a reason to not inject it?

5. +++ b/core/modules/language/lib/Drupal/language/Form/NegotiationConfigureForm.php
   @@ -0,0 +1,241 @@
   +    drupal_set_message(t('Language negotiation configuration saved.'));
   

   All of the t() should be $this->t()

NW as per #10.

Some fixes.

:/

slight typo, this should fix it.

+++ w/core/modules/language/lib/Drupal/language/Form/NegotiationConfigureForm.php
@@ -0,0 +1,296 @@
+  /**
+   * Stores the configuration configuration object for system.language.types.
+   *
+   * @var \Drupal\Core\Config\Config
+   */
+  protected $config;
...
+    $this->config = $config_factory->get('system.language.types');

I'd prefer to store the entire configFactory so if another module extends this, and needs a different config, they'd be able to get it still, without reinjecting the configFactory. If you aren't going to store the factory, at least specify what config this is instead of just $config.

Some fixes and tested manually works fine.

I can live with that. If it passes, RTBC.

oops

just can't win...

Seems like the patch no longer applies

Here's a re-roll and minor tweaks around the handling of the block manager.

I manually tested the page and it worked as expected. The code looks fine as well.

Committed and pushed to 8.x. Thanks!