Add support for touch icons:

Original request:

See https://developer.apple.com/library/ios/documentation/AppleApplications/... for documentation.

The tag value contains three comma-separated parameters; I'm not completely familiar with the Meta Tag API yet, but I think it would be ideal if these were implemented as separate fields and then combined automatically.

CommentFileSizeAuthor
#16 metatag-n2085747-16.patch8.21 KBdamienmckenna
#14 metatag-n2085747-14.patch5.7 KBdamienmckenna
#5 smartappbanners-2085747.patch2.33 KBjazzslider
#3 smartappbanners-2085747.patch2.75 KBjazzslider
#1 smartappbanners-2085747.patch2.76 KBjazzslider

Comments

jazzslider’s picture

jazzslider commented
Status: Active » Needs review
StatusFileSize
new smartappbanners-2085747.patch2.76 KB

The attached patch implements a very basic version of this. I did not, unfortunately, see a way to implement the three named parameters as separate fields, so those using this tag will have to enter the entire string as defined in the docs. That's probably acceptable to most people who would use this.

jbrown’s picture

jbrown commented
Status: Needs review » Needs work

Shouldn't it be
<meta name="apple-itunes-app" content="app-id=#" />

instead of

<meta property="apple-itunes-app" content="app-id=#" />

jazzslider’s picture

jazzslider commented
Issue summary: View changes
StatusFileSize
new smartappbanners-2085747.patch2.75 KB

Indeed it should —thanks for the catch, I've updated the patch accordingly.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I think this needs some a little further work:

  • Please don't provide a 160 character long URL as part of the help text :) This should be the URL of a link, e.g. "Parameters for configuring the [link]Smart App Banner[/link]."
  • I don't think you need the custom theme function, the default should work.
jazzslider’s picture

jazzslider commented
StatusFileSize
new smartappbanners-2085747.patch2.33 KB

Please see my latest patch, which implements your recommendations.

Thanks!
Adam

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Add support for apple-itunes-app meta tag » Add support for Apple's custom meta tags

Lets expand this to cover Apple's other meta tags too.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Closed a duplicate: #2382749: Add support for apple-touch-icon link meta tags

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Note that 'apple-touch-icon' is used by a lot more than just Apple devices, so caution in how it's labeled otherwise it might be easily ignored.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

For reference: https://mathiasbynens.be/notes/touch-icons

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Add support for Apple's custom meta tags » Add support for touch icons
Issue summary: View changes

Lets refocus the request.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.0-beta7 » 7.x-1.x-dev
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Related project: https://www.drupal.org/project/responsive_favicons

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

+1 for the responsive_favicons module, it and the service it uses (http://realfavicongenerator.net/) work really well.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2085747-14.patch5.7 KB

This adds a bunch of favicon formats, but needs some further work; uploading it here so I don't accidentally loose what I'm working on.

FYI I figure that this could focus on adding favicons and favicon-type meta tags.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Add support for touch icons » Add new meta tags: touch icons

Standardized the issue title.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2085747-16.patch8.21 KB

This tidies up the code a bit, makes the meta tags only work globally, and the output works now.

  • DamienMcKenna committed dd87eff on 7.x-1.x 
    Issue #2085747 by DamienMcKenna: Added twelve favicon varieties to a new...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Woot!

Please open new issues for any other favicons that could be added.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.