Having node access modules enabled on a site can cause a number of complications. Any of them disable block caching, and multiple ones can cause unexpected behavior.

Let's record what modules, if any, implement these hooks on the site.

CommentFileSizeAuthor
#6 2085055.D6.do-not-test.patch968 bytesgcassie
#4 2085055.patch840 bytesgcassie
#1 2085055.patch864 bytesgcassie

Comments

gcassie’s picture

gcassie commented
Status: Active » Needs review
StatusFileSize
new 2085055.patch864 bytes

Status: Needs review » Needs work

The last submitted patch, 2085055.patch, failed testing.

coltrane’s picture

coltrane
he/him
commented

Logs say "[fatal: corrupt patch at line 23]." @gcassie what command did you roll this with?

gcassie’s picture

gcassie commented
Status: Needs work » Needs review
StatusFileSize
new 2085055.patch840 bytes

I think it was manually adjusted from another patch. Here's a straight git diff. Also a slight change from last time - we'll just send along node_node_access and strip it out in the current test.

coltrane’s picture

coltrane
he/him
commented

Looks good! Do you have this as a D6 patch too?

gcassie’s picture

gcassie commented
StatusFileSize
new 2085055.D6.do-not-test.patch968 bytes

Yep, attached.

coltrane’s picture

coltrane
he/him
commented
Status: Needs review » Needs work

@gcassie is #4 updated with your unified patch from NR-282? It seems that you removed the handling of node_node_access()

gcassie’s picture

gcassie commented

Yes, that handling was removed from client side, and is now handled in the Insight test.

coltrane’s picture

coltrane
he/him
commented
Status: Needs work » Fixed

Committed, thank you! http://drupalcode.org/project/acquia_connector.git/commit/3ef9278 and http://drupalcode.org/project/acquia_connector.git/commit/22453da

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.