Having node access modules enabled on a site can cause a number of complications. Any of them disable block caching, and multiple ones can cause unexpected behavior.

Let's record what modules, if any, implement these hooks on the site.

CommentFileSizeAuthor
#6 2085055.D6.do-not-test.patch968 bytesgcassie
#4 2085055.patch840 bytesgcassie
PASSED: [[SimpleTest]]: [MySQL] 356 pass(es). View
#1 2085055.patch864 bytesgcassie
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2085055.patch. Unable to apply patch. See the log in the details link for more information. View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

gcassie’s picture

Status: Active » Needs review
FileSize
864 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2085055.patch. Unable to apply patch. See the log in the details link for more information. View

Status: Needs review » Needs work

The last submitted patch, 2085055.patch, failed testing.

coltrane’s picture

Logs say "[fatal: corrupt patch at line 23]." @gcassie what command did you roll this with?

gcassie’s picture

Status: Needs work » Needs review
FileSize
840 bytes
PASSED: [[SimpleTest]]: [MySQL] 356 pass(es). View

I think it was manually adjusted from another patch. Here's a straight git diff. Also a slight change from last time - we'll just send along node_node_access and strip it out in the current test.

coltrane’s picture

Looks good! Do you have this as a D6 patch too?

gcassie’s picture

FileSize
968 bytes

Yep, attached.

coltrane’s picture

Status: Needs review » Needs work

@gcassie is #4 updated with your unified patch from NR-282? It seems that you removed the handling of node_node_access()

gcassie’s picture

Yes, that handling was removed from client side, and is now handled in the Insight test.

coltrane’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.