The installer uses quite a bit of unnecessary and redundant text to superfluously inform users of what the form does. This is unneeded and this duplication makes the form more complex than it should be. Besides all this, the whole form is repetitive and most of all just needlessly wordy.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Assigned: Xano » Unassigned
Status: Active » Needs review
FileSize
5.63 KB

Status: Needs review » Needs work

The last submitted patch, drupal_2084665_1.patch, failed testing.

Xano’s picture

FileSize
209.97 KB

This is the current installer with comments marking the things that the patch tries to fix.
Image 9-9-13 at 9.30 .png

Xano’s picture

Status: Needs work » Needs review
FileSize
6.43 KB

Status: Needs review » Needs work

The last submitted patch, drupal_2084665_4.patch, failed testing.

Xano’s picture

Status: Needs work » Needs review
FileSize
63.21 KB

The patch:

  1. removes redundant occurences of the word "database"
  2. removed redundant element descriptions
  3. explains what a table prefix does
  4. removes descriptions that IMHO are degrading or obvious, but those will need a review from other people

Screen Shot 2013-09-09 at 9.38.48 .png

Xano’s picture

FileSize
6.49 KB

I removed an additional "Database" and converted the DB port to a number element.

Xano’s picture

FileSize
6.49 KB

I removed an additional "Database" and converted the DB port to a number element.

Xano’s picture

FileSize
6.49 KB

The element must be a number, not a range.

Status: Needs review » Needs work

The last submitted patch, drupal_2084665_9.patch, failed testing.

Xano’s picture

FileSize
7.08 KB

And without duplicate validation.

LewisNyman’s picture

Issue tags: +Usability
sphism’s picture

I like it.

One thing though, the text field boxes are all very wide. Would it be possible to have the field label inline with it's field?

I guess in different languages maybe it could be an issue ???

Does the installer come in different languages?

Xano’s picture

Status: Needs work » Needs review

One thing though, the text field boxes are all very wide. Would it be possible to have the field label inline with it's field?

That's not what this issue is about, and we hardly do that anywhere at all. Let's keep things consistent, unless there is a good reason to do it differently.

I guess in different languages maybe it could be an issue ???

Does the installer come in different languages?

It does.

Status: Needs review » Needs work

The last submitted patch, drupal_2084665_11.patch, failed testing.

Bojhan’s picture

Why even display a disabled radio?

flefle’s picture

@ Bojhan: you could have various options regarding your available database systems installed on the platform.

Patch #11 is working fine after testing on the latest D8 - dev branch. I agree on removing the unnecessary text and description since the fields are self explaining and used in a routine way. Personally it's making a better - minimalistic experience and I'm suggesting this patch to be ported into D8.

jthorson’s picture

The testbot failures here are because the PIFR code does an AssertText on "Database name" to detect successful load of the database configuration change.

If this were to go in as is, we would first need to add some version-specific conditional code to PIFR to ensure that we don't break testing.

aschiwi’s picture

FileSize
93.03 KB
153.06 KB

Reviewing this during as part of a usability review drupalmentoring task. Here's my two cents:

I have to admit that removing the "database" part from the labels ends up being more confusing from a usability experience. I know it says "Database configuration" as the title but lots of people might skip reading that and others might still not know what is meant by "name" and "user name". I know I wouldn't have known when I first started installing Drupal.

Here's what that page looks like now:

db-config.jpg

Everything in "Advanced Options" is okay for me. In the main options, I feel it would make more sense and help people if the labels said "Database Type", "Database Name", "Database Username", "Database Password". I also agree that the radio button isn't needed, if no other options will ever be available.

Here's what my proposed change with the labels would look like, still clean enough imho:

proposed change

sandipmkhairnar’s picture

Status: Needs work » Needs review
sandipmkhairnar’s picture

Status: Needs review » Needs work
Xano’s picture

Status: Needs work » Needs review
FileSize
7.08 KB

Re-roll.

Status: Needs review » Needs work

The last submitted patch, drupal_2084665_22.patch, failed testing.

yoroy’s picture

Good cleanup overall but I agree with aschiwi. Removing all mentions of “database” from the labels takes things a bit too far. It makes this page rely too much on the page title to know what this is about and it's especially page titles that are most easily glossed over by people.

Adding the “database” word back to the first three fields would be good. A bit more redundant but a lot more specific and helpful.

Xano’s picture

Adding the “database” word back to the first three fields would be good.

So type, name, and username? Or did you mean the first four fields?

yoroy’s picture

Heh I overlooked 'type'. First four indeed.

Xano’s picture

Status: Needs work » Needs review
FileSize
6.4 KB
1.54 KB
Xano’s picture

FileSize
6.4 KB

Double post. Ignore this patch.

Status: Needs review » Needs work

The last submitted patch, drupal_2084665_27.patch, failed testing.

Xano’s picture

Status: Needs work » Needs review
Xano’s picture

@yoroy, could you review the latest patch? It incorporates your feedback from #24.

Xano’s picture

27: drupal_2084665_27.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 27: drupal_2084665_27.patch, failed testing.

Xano’s picture

Issue summary: View changes
FileSize
6.49 KB

Re-roll.

Bojhan’s picture

Status: Needs work » Reviewed & tested by the community

D.O status workflow-----

This patch is cool, seems like the main concern is addressed - marking it RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice clean-up! I think my favourite is: "Database name" : "The name of the database your @drupal data will be stored in." ;)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.