Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The installer uses quite a bit of unnecessary and redundant text to superfluously inform users of what the form does. This is unneeded and this duplication makes the form more complex than it should be. Besides all this, the whole form is repetitive and most of all just needlessly wordy.
Comment | File | Size | Author |
---|---|---|---|
#34 | drupal_2084665_34.patch | 6.49 KB | Xano |
#28 | drupal_2084665_27.patch | 6.4 KB | Xano |
#27 | interdiff.txt | 1.54 KB | Xano |
#27 | drupal_2084665_27.patch | 6.4 KB | Xano |
#22 | drupal_2084665_22.patch | 7.08 KB | Xano |
Comments
Comment #1
XanoComment #3
XanoThis is the current installer with comments marking the things that the patch tries to fix.
Comment #4
XanoComment #6
XanoThe patch:
Comment #7
XanoI removed an additional "Database" and converted the DB port to a number element.
Comment #8
XanoI removed an additional "Database" and converted the DB port to a number element.
Comment #9
XanoThe element must be a number, not a range.
Comment #11
XanoAnd without duplicate validation.
Comment #12
LewisNyman CreditAttribution: LewisNyman commentedComment #13
sphism CreditAttribution: sphism commentedI like it.
One thing though, the text field boxes are all very wide. Would it be possible to have the field label inline with it's field?
I guess in different languages maybe it could be an issue ???
Does the installer come in different languages?
Comment #14
XanoThat's not what this issue is about, and we hardly do that anywhere at all. Let's keep things consistent, unless there is a good reason to do it differently.
It does.
Comment #16
Bojhan CreditAttribution: Bojhan commentedWhy even display a disabled radio?
Comment #17
flefle CreditAttribution: flefle commented@ Bojhan: you could have various options regarding your available database systems installed on the platform.
Patch #11 is working fine after testing on the latest D8 - dev branch. I agree on removing the unnecessary text and description since the fields are self explaining and used in a routine way. Personally it's making a better - minimalistic experience and I'm suggesting this patch to be ported into D8.
Comment #18
jthorson CreditAttribution: jthorson commentedThe testbot failures here are because the PIFR code does an AssertText on "Database name" to detect successful load of the database configuration change.
If this were to go in as is, we would first need to add some version-specific conditional code to PIFR to ensure that we don't break testing.
Comment #19
aschiwi CreditAttribution: aschiwi commentedReviewing this during as part of a usability review drupalmentoring task. Here's my two cents:
I have to admit that removing the "database" part from the labels ends up being more confusing from a usability experience. I know it says "Database configuration" as the title but lots of people might skip reading that and others might still not know what is meant by "name" and "user name". I know I wouldn't have known when I first started installing Drupal.
Here's what that page looks like now:
Everything in "Advanced Options" is okay for me. In the main options, I feel it would make more sense and help people if the labels said "Database Type", "Database Name", "Database Username", "Database Password". I also agree that the radio button isn't needed, if no other options will ever be available.
Here's what my proposed change with the labels would look like, still clean enough imho:
Comment #20
sandipmkhairnar CreditAttribution: sandipmkhairnar commentedComment #21
sandipmkhairnar CreditAttribution: sandipmkhairnar commentedComment #22
XanoRe-roll.
Comment #24
yoroy CreditAttribution: yoroy commentedGood cleanup overall but I agree with aschiwi. Removing all mentions of “database” from the labels takes things a bit too far. It makes this page rely too much on the page title to know what this is about and it's especially page titles that are most easily glossed over by people.
Adding the “database” word back to the first three fields would be good. A bit more redundant but a lot more specific and helpful.
Comment #25
XanoSo type, name, and username? Or did you mean the first four fields?
Comment #26
yoroy CreditAttribution: yoroy commentedHeh I overlooked 'type'. First four indeed.
Comment #27
XanoComment #28
XanoDouble post. Ignore this patch.
Comment #30
XanoComment #31
Xano@yoroy, could you review the latest patch? It incorporates your feedback from #24.
Comment #32
Xano27: drupal_2084665_27.patch queued for re-testing.
Comment #34
XanoRe-roll.
Comment #35
Bojhan CreditAttribution: Bojhan commentedD.O status workflow-----
This patch is cool, seems like the main concern is addressed - marking it RTBC.
Comment #36
webchickNice clean-up! I think my favourite is: "Database name" : "The name of the database your @drupal data will be stored in." ;)
Committed and pushed to 8.x. Thanks!