Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
routing system
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Sep 2013 at 17:36 UTC
Updated:
29 Jul 2014 at 22:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerThere we go
Comment #3
dawehnerWrong patch ...
Comment #4
dawehnerWrong patch ...
Comment #5
pwolanin commenteddisables 2 tests:
Comment #6
dawehnerThere we go.
Comment #7
pwolanin commentedThis looks good - should have been translated from the start.
Comment #8
pwolanin commentedComment #9
aspilicious commentedDurpal ==> intentional?
Comment #10
dawehner.
Comment #11
pwolanin commentedThat's the way I might tend to type it :) but looks better now.
Comment #12
webchick(nitpick) That comment needs to be a sentence ending with a period, but...
How is that actually translating anything? Is the comment wrong, or the code?
Comment #13
dawehnerOh the comment is just stupid, here some a better one.
Comment #14
pwolanin commentedI find
protected $translationManager;a little odd as the variable name, but already used all over core.Comment #16
dawehnerReupload to not destroy the testrun.
Comment #17
webchickCommitted and pushed to 8.x. Thanks!