Server processing messages and set variables automatically

1. +++ b/acquia_agent/acquia_agent.module
   @@ -549,6 +549,8 @@ function acquia_agent_help($path, $arg) {
   +      $output .= '<dt>' . t('Allow Insight to update list of approved variables') . '</dt>';
   

   Sentence should end with a period to match (most of) the other options on the page.

2. +++ b/acquia_spi/acquia_spi.module
   @@ -140,21 +141,39 @@ function _acquia_spi_send_access() {
   +        $message .= t(' Acquia Network returned the following messages. Further information may also be logged. <br/>');
   

   Translated strings shouldn't start with a space, and the break tag should be outside the t().

3. +++ b/acquia_spi/acquia_spi.module
   @@ -140,21 +141,39 @@ function _acquia_spi_send_access() {
   +          $message .= check_plain($nspi_message) . '<br/>';
   

   Actually maybe just make a $messages array and then implode it in the dsm call.

4. +++ b/acquia_spi/acquia_spi.module
   @@ -261,6 +280,12 @@ function acquia_spi_form_acquia_agent_settings_form_alter(&$form) {
   +    '#title' => t('Allow Insight to update list of approved variables'),
   

   End with a period.

5. +++ b/acquia_spi/acquia_spi.module
   @@ -1420,3 +1466,48 @@ function acquia_spi_hash_path($path = '') {
   +      variable_set($key, $value);
   

   We should do a variable_get after the variable_set to see if the value actually changed. If it didn't that's a sign it's being set in $conf or strongarm or such and we can set a notification that the subscriber is going to have to make the change themselves.

Why do you have to test that the variable changed on a page refresh? If you do a variable_set() the new value is immediately available in a variable_get(). So something like:

  $failures = array();
  foreach($set_variables as $key => $value) {
    // Approved variables get set immediately unless ignored.
    if (in_array($key, $whitelist) && !in_array($key, $ignored)) {
      $tmp = variable_get($key, NULL);
      $saved[] = $key;
      variable_set($key, $value);
      if (variable_get($key, NULL) != $tmp) {
        $failures[$key] = $value;
      }
    }
  }

And then report back on $failures.

Otherwise looks good.