Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/lib/Drupal/Core/EventSubscriber/RedirectResponseSubscriber.php

Line 50: Unused local variable $redirect_path

CommentFileSizeAuthor
#2 drupal-core-remove-unused-local-variable-2081209.patch773 bytesmrsinguyen

Comments

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Active » Needs work
mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2081209.patch773 bytes

Attached patch.

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, drupal-core-remove-unused-local-variable-2081209.patch, failed testing.

mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review
Issue tags: +Novice

#2: drupal-core-remove-unused-local-variable-2081209.patch queued for re-testing.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.