Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/tour/tour.module

Line 116: Unused local variable $tour_items

CommentFileSizeAuthor
#1 drupal8.other_.2081187-1.patch471 bytessmira
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smira’s picture

smira CreditAttribution: smira commented
Status: Active » Needs review
FileSize
drupal8.other_.2081187-1.patch471 bytes

wtf is the tour module?

Barrett’s picture

Barrett CreditAttribution: Barrett commented
Status: Needs review » Reviewed & tested by the community

Patch is simple and clean and tests pass following application.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

1: drupal8.other_.2081187-1.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: drupal8.other_.2081187-1.patch, failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review

1: drupal8.other_.2081187-1.patch queued for re-testing.

parthipanramesh’s picture

parthipanramesh CreditAttribution: parthipanramesh commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

tested.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.