Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/datetime/lib/Drupal/datetime/Plugin/field/widget/DatetimeDatelistWidget.php

Line 85: Unused local variable $type_type

CommentFileSizeAuthor
#4 2081163-4.patch1.08 KBareke
#2 drupal8.other_.2081163-2.patch709 bytessmira
#1 drupal8.other_.2081163-1.patch0 bytessmira
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smira’s picture

smira CreditAttribution: smira commented
Status: Active » Needs review
FileSize
drupal8.other_.2081163-1.patch0 bytes
smira’s picture

smira CreditAttribution: smira commented
FileSize
drupal8.other_.2081163-2.patch709 bytes
parthipanramesh’s picture

parthipanramesh CreditAttribution: parthipanramesh commented
Issue summary: View changes
Status: Needs review » Needs work

can't apply patch..

areke’s picture

areke CreditAttribution: areke commented
Status: Needs work » Needs review
FileSize
2081163-4.patch1.08 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2081163-4.patch, failed testing.

areke’s picture

areke CreditAttribution: areke commented
Status: Needs work » Needs review

4: 2081163-4.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2081163-4.patch, failed testing.

areke’s picture

areke CreditAttribution: areke commented
Status: Needs work » Needs review

4: 2081163-4.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Title: Remove Unused local variable $type_type from /datetime/lib/Drupal/datetime/Plugin/field/widget/DatetimeDatelistWidget.php » Remove unused local variables from the datetime module
Component: other » datetime.module
Priority: Normal » Minor

Let's also check the rest of the module and confirm that there are no other unused local variables.

enhdless’s picture

enhdless CreditAttribution: enhdless commented

Patch #4 looks good to me

parthipanramesh’s picture

parthipanramesh CreditAttribution: parthipanramesh commented
Status: Needs review » Reviewed & tested by the community

Looks fine.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.