Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables
File /core/modules/content_translation/content_translation.module
Line 236: Unused local variable $entity_position
Line 279: Unused local variable $entity_type
Line 858: Unused local variable $field_type
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | drupal-core-remove-unused-local-variable-2081149-10.patch | 1.17 KB | deneo |
| #5 | 2081149-5.patch | 1.98 KB | areke |
| #4 | 2081149-4.patch | 3.65 KB | areke |
| #1 | drupal-core-remove-unused-local-variable-2081149.patch | 1.7 KB | mrsinguyen |
Comments
Comment #1
mrsinguyen commentedComment #2
enhdless commentedUnfortunately, the patch failed to apply.
Comment #3
areke commentedComment #4
areke commentedRe-rolled.
Comment #5
areke commentedI accidentally provided the wrong patch before.
Comment #6
areke commentedComment #7
areke commentedComment #10
deneo commentedComment #11
areke commentedOops, it looks like the variable $entity_type does actually get used. The patch that deneo provided applies cleanly and doesn't take remove $entity_type, so it is the right patch. The patch looks good!
Comment #12
webchickCommitted and pushed to 8.x. Thanks!