Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/taxonomy/lib/Drupal/taxonomy/Tests/Views/TaxonomyTestBase.php

Line 70: Unused local variable $type
Line 94: Unused local variable $instance

CommentFileSizeAuthor
#4 drupal_core-remove-unused-variable-2081131-4.patch969 bytesdeneo2
#2 drupal-core-remove-unused-local-variable-2081131.patch2.96 KBmrsinguyen
#1 drupal-core-remove-unused-local-variable-2081131.patch969 bytesmrsinguyen

Comments

mrsinguyen’s picture

mrsinguyen commented
Status: Active » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2081131.patch969 bytes
mrsinguyen’s picture

mrsinguyen commented
StatusFileSize
new drupal-core-remove-unused-local-variable-2081131.patch2.96 KB

Combine issues:
- #2081129: Remove Unused local variable $key from /core/modules/taxonomy/lib/Drupal/taxonomy/Tests/VocabularyTest.php
- #2081125: Remove Unused local variable $config from /core/modules/taxonomy/taxonomy.install
- #2081123: Remove Unused local variable $delta from /core/modules/taxonomy/taxonomy.module
- #2081121: Remove Unused local variable $matches from /core/modules/taxonomy/taxonomy.pages.inc

areke’s picture

areke commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

The patch no longer applies.

deneo2’s picture

deneo2 commented
Status: Needs work » Needs review
StatusFileSize
new drupal_core-remove-unused-variable-2081131-4.patch969 bytes

It only solve this issue

areke’s picture

areke commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

The patch looks good. Thank you!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.