Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/syslog/lib/Drupal/syslog/Tests/SyslogTest.php

Line 39: Unused local variable $edit

CommentFileSizeAuthor
#6 drupal-code-unused-variable-2081115-6.patch709 bytesdeneo
#4 2081115-4.patch1.03 KBareke
#1 drupal-core-remove-unused-local-variable-2081115.patch705 bytesmrsinguyen

Comments

mrsinguyen’s picture

mrsinguyen commented
StatusFileSize
new drupal-core-remove-unused-local-variable-2081115.patch705 bytes
haza’s picture

haza
Primary language French
commented
Status: Active » Needs review
parthipanramesh’s picture

parthipanramesh commented
Issue summary: View changes
Status: Needs review » Needs work

patching failed..

areke’s picture

areke commented
Status: Needs work » Needs review
StatusFileSize
new 2081115-4.patch1.03 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2081115-4.patch, failed testing.

deneo’s picture

deneo commented
Status: Needs work » Needs review
StatusFileSize
new drupal-code-unused-variable-2081115-6.patch709 bytes
areke’s picture

areke commented

4: 2081115-4.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Remove Unused local variable $edit from /core/modules/syslog/lib/Drupal/syslog/Tests/SyslogTest.php » Remove Unused local variables from the syslog module
Component: other » syslog.module
Priority: Normal » Minor

Let's also check the rest of the module and confirm that there are no other unused local variables.

enhdless’s picture

enhdless commented

Patch #6 works great.

eugenesia’s picture

eugenesia commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +LONDON_2013_DECEMBER

Just finishing up the issue I started looking at in LONDON_2013_DECEMBER yesterday. I applied patch #6, and all Simpletest tests passed for the syslog module. I checked visually and with PhpStorm and I confirm that there are no other unused local variables in the syslog module.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.