Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Right now acquia_spi_check_login() only accounts for the Secure Pages module, but Secure Login is also able to force user authentication over HTTPS.
Comment | File | Size | Author |
---|---|---|---|
#12 | 2081003.D6.do-not-test.patch | 843 bytes | coltrane |
#11 | 2081003.D6.do-not-test.patch | 1000 bytes | gcassie |
#9 | 2081003.patch | 1.57 KB | gcassie |
#7 | 2081003.patch | 1.57 KB | gcassie |
#4 | 2081045.patch | 4.3 KB | gcassie |
Comments
Comment #1
gcassie CreditAttribution: gcassie commentedComment #2
coltraneMinor: capitalize and end in period please
Needs a default or else throws a notice
Needs default
Comment #3
coltraneAlso, "elseif" please per https://drupal.org/coding-standards
Comment #4
gcassie CreditAttribution: gcassie commentedThanks. Updated patch.
Comment #6
coltrane@gcassie #4 patch looks to be to evergage module and not acquia_spi
Comment #7
gcassie CreditAttribution: gcassie commentedLet's try that again.
Comment #8
coltraneSecure Pages still needs mixed mode support https://drupal.org/project/securepages so the variable 'https' would be TRUE. What do you think about leaving out that check and just relying on the forms?
Comment #9
gcassie CreditAttribution: gcassie commentedSorry, that ! on the variable_get('https', FALSE) check is wrong (new patch). I think we should still check for it, though - relying on just the forms doesn't actually make for a secure login, does it?
Comment #10
coltraneOn further review I think your first patch (#7) is actually correct. For securelogin support $conf['https'] should be FALSE, so the !variable_get() will evaluate TRUE. I'll do little more testing and then commit.
Comment #11
gcassie CreditAttribution: gcassie commentedYes, I got the two module names crossed as we talked - #7 is what we want I think. Here is a D6 version of it.
Comment #12
coltraneconf['https'] didn't exist in Drupal 6 so quick reroll
Comment #13
coltraneCommitted. http://drupalcode.org/project/acquia_connector.git/commit/bbe2e25 and http://drupalcode.org/project/acquia_connector.git/commit/f8edb06