Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/shortcut/lib/Drupal/shortcut/Tests/ShortcutTestBase.php

Line 131: Unused local variable $uuid

CommentFileSizeAuthor
#1 2080713-remove-unused-variables.patch626 byteschertzog

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Status: Active » Needs review
StatusFileSize
new 2080713-remove-unused-variables.patch626 bytes
barrett’s picture

barrett commented
Status: Needs review » Reviewed & tested by the community

Patch applies, addresses stated problem, and related tests continue to pass. I know we normally require two reviews to RTBC a patch, but this is so simple it seems like overkill in this case.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

1: 2080713-remove-unused-variables.patch queued for re-testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

1: 2080713-remove-unused-variables.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.