Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/shortcut/shortcut.module

Line 393: Unused local variable $id
Line 473: Unused local variable $uuid

CommentFileSizeAuthor
#1 2080711-remove-unused-variables.patch916 byteschertzog

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Status: Active » Needs review
StatusFileSize
new 2080711-remove-unused-variables.patch916 bytes
smira’s picture

smira commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

smira’s picture

smira commented
Status: Needs work » Needs review
Issue tags: -Novice, -Needs reroll

#1: 2080711-remove-unused-variables.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +Needs reroll

The last submitted patch, 2080711-remove-unused-variables.patch, failed testing.

mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Fixed

Two the variables above gone in lasted 8.x

Automatically closed -- issue fixed for 2 weeks with no activity.