Remove Unused local variable $key from /core/modules/field/lib/Drupal/field/Tests/Views/HandlerFieldFieldTest.php [#2080671]

Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/field/lib/Drupal/field/Tests/Views/HandlerFieldFieldTest.php

Line 87: Unused local variable $key
Line 158: Unused local variable $rendered_field

Comment	File	Size	Author
#6	drupal8.unused_var.2080671-6.patch	1.14 KB	royal121
#4	drupal8.unused_var.2080671-4.patch	1.19 KB	mcrittenden
#1	2080671.remove_unused_variable.patch	1.27 KB	haza

Comments

Comment #1

haza

French

commented 5 September 2013 at 08:33

Status:

Active

» Needs review

Status	File	Size
new	2080671.remove_unused_variable.patch	1.27 KB

Comment #2

longwave

he/him

English

commented 5 September 2013 at 10:03

-    // Test that an empty field is rendered without error.
-    $rendered_field = $view->style_plugin->getField(4, $this->fields[4]['field_name']);

This seems like it is testing something, even if there is no assertion.

Comment #3

g.i.joe commented 25 September 2013 at 21:56

Status:

Needs review

» Needs work

+++ b/core/modules/field/lib/Drupal/field/Tests/Views/HandlerFieldFieldTest.php
@@ -164,9 +164,6 @@ public function _testMultipleFieldRender() {
-    // Test that an empty field is rendered without error.
-    $rendered_field = $view->style_plugin->getField(4, $this->fields[4]['field_name']);
-

just remove the variable and leave the function intact because we don't know the field could be rendered without error.