Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/user/lib/Drupal/user/Tests/Views/HandlerFieldRoleTest.php

Line 35: Unused local variable $rid_a
Line 38: Unused local variable $rid_b

CommentFileSizeAuthor
#3 drupal-core-remove-unused-local-variable-2080607-3.patch1.06 KBCaptainWonky
#2 drupal-core-remove-unused-local-variable-2080607-2.patch913 bytesCaptainWonky
#1 drupal-core-remove-unused-local-variable-2080607.patch0 bytesmrsinguyen

Comments

mrsinguyen’s picture

mrsinguyen commented
Status: Active » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080607.patch0 bytes
CaptainWonky’s picture

CaptainWonky commented
StatusFileSize
new drupal-core-remove-unused-local-variable-2080607-2.patch913 bytes

Last patch was empty

Here's another:

CaptainWonky’s picture

CaptainWonky commented
StatusFileSize
new drupal-core-remove-unused-local-variable-2080607-3.patch1.06 KB

Oops, bad patch.

This one should be better:

areke’s picture

areke commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I believe everything looks good in this patch. RTBC

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.