Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/user/lib/Drupal/user/Tests/UserRegistrationTest.php

Line 88: Unused local variable $new_user

CommentFileSizeAuthor
#6 drupal8.registration-test.2080601-6.patch865 bytesmcrittenden
#4 drupal-core-remove-unused-local-variable-2080601-4.patch843 bytesmrsinguyen
#1 drupal-core-remove-unused-local-variable-2080601.patch839 bytesmrsinguyen

Comments

mrsinguyen’s picture

mrsinguyen commented
Status: Active » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080601.patch839 bytes
sandergo90’s picture

sandergo90 commented
Status: Needs review » Reviewed & tested by the community

The patch successfully applied and looks fine. The variable is now gone and everything passes the testing framework.

Drupal coding standards are applied.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080601-4.patch843 bytes
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/core/modules/user/lib/Drupal/user/Tests/UserRegistrationTest.php
@@ -85,7 +85,6 @@ function testRegistrationWithoutEmailVerification() {
     $accounts = entity_load_multiple_by_properties('user', array('name' => $name, 'mail' => $mail));
-    $new_user = reset($accounts);

We should probably check that the user is created instead of removing the variable

mcrittenden’s picture

mcrittenden commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new drupal8.registration-test.2080601-6.patch865 bytes

Using the recommendation in #5.

parthipanramesh’s picture

parthipanramesh commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good to me!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.