Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/user/lib/Drupal/user/Tests/UserLanguageTest.php

Line 36: Unused local variable $base_url

CommentFileSizeAuthor
#2 drupal-core-remove-unused-local-variable-2080597-2.patch680 bytessandergo90
#1 drupal-core-remove-unused-local-variable-2080597.patch633 bytesmrsinguyen

Comments

mrsinguyen’s picture

mrsinguyen commented
Status: Active » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080597.patch633 bytes
sandergo90’s picture

sandergo90 commented
StatusFileSize
new drupal-core-remove-unused-local-variable-2080597-2.patch680 bytes

The patch was not successful. There still remains a blank line under the function declaration. I have created a patch to delete that one to.

parthipanramesh’s picture

parthipanramesh commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.